Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 299153004: Move child process observing from MetricsService to stability provider. (Closed)

Created:
6 years, 7 months ago by Alexei Svitkine (slow)
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, blundell
Visibility:
Public.

Description

Move child process observing from MetricsService to stability provider. Also moves the prefs registration to the stability provider. BUG=374206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272679

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -37 lines) Patch
M chrome/browser/metrics/chrome_stability_metrics_provider.h View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_stability_metrics_provider.cc View 1 2 4 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 6 chunks +3 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alexei Svitkine (slow)
6 years, 7 months ago (2014-05-23 11:02:03 UTC) #1
Ilya Sherman
Nice! One quick question: https://codereview.chromium.org/299153004/diff/20001/chrome/browser/metrics/chrome_stability_metrics_provider.cc File chrome/browser/metrics/chrome_stability_metrics_provider.cc (right): https://codereview.chromium.org/299153004/diff/20001/chrome/browser/metrics/chrome_stability_metrics_provider.cc#newcode27 chrome/browser/metrics/chrome_stability_metrics_provider.cc:27: #endif Hmm, maybe it makes ...
6 years, 7 months ago (2014-05-23 11:42:01 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/299153004/diff/20001/chrome/browser/metrics/chrome_stability_metrics_provider.cc File chrome/browser/metrics/chrome_stability_metrics_provider.cc (right): https://codereview.chromium.org/299153004/diff/20001/chrome/browser/metrics/chrome_stability_metrics_provider.cc#newcode27 chrome/browser/metrics/chrome_stability_metrics_provider.cc:27: #endif On 2014/05/23 11:42:01, Ilya Sherman wrote: > Hmm, ...
6 years, 7 months ago (2014-05-23 13:14:50 UTC) #3
Ilya Sherman
LGTM https://codereview.chromium.org/299153004/diff/20001/chrome/browser/metrics/chrome_stability_metrics_provider.cc File chrome/browser/metrics/chrome_stability_metrics_provider.cc (right): https://codereview.chromium.org/299153004/diff/20001/chrome/browser/metrics/chrome_stability_metrics_provider.cc#newcode27 chrome/browser/metrics/chrome_stability_metrics_provider.cc:27: #endif On 2014/05/23 13:14:50, Alexei Svitkine wrote: > ...
6 years, 7 months ago (2014-05-23 14:21:16 UTC) #4
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-23 14:45:32 UTC) #5
Alexei Svitkine (slow)
The CQ bit was unchecked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-23 14:46:06 UTC) #6
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-23 21:58:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/299153004/70001
6 years, 7 months ago (2014-05-23 21:58:51 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 01:48:18 UTC) #9
Message was sent while issue was closed. 
Change committed as 272679

Powered by Google App Engine
This is Rietveld 408576698