content/browser/appcache/appcache_subresource_url_factory.h - Issue 2991443002: The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_subresource_url_factory.h

Issue 2991443002: The Appcache subresource URL factory needs to inform the URLLoaderClient if there is a failure. (Closed)

Patch Set: Add browser test for verifying that navigating to a TLD within the same host which had an AppCache … Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_subresource_url_factory.h

diff --git a/content/browser/appcache/appcache_subresource_url_factory.h b/content/browser/appcache/appcache_subresource_url_factory.h

index ef4458e8a5129e50d466a159830a27228e0261bf..bfed6d2739229420f0c9326307433c3e80b18136 100644

--- a/content/browser/appcache/appcache_subresource_url_factory.h

+++ b/content/browser/appcache/appcache_subresource_url_factory.h

@@ -59,6 +59,10 @@ class AppCacheSubresourceURLFactory : public mojom::URLLoaderFactory {

void OnConnectionError();

+ // Notifies the |client| if there is a failure. The |error_code| contains the

+ // actual error.

+ void NotifyError(mojom::URLLoaderClientPtr client, int error_code);

// Mojo binding.

mojo::Binding<mojom::URLLoaderFactory> binding_;