Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 299143007: Show flags in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js + code review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/vm_view.html ('k') | runtime/vm/flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart
index 9665991c2a1e574c14cedfb0d2bfae723cacff30..d52119bdc0a635191ebeac917e508f5e73e9f465 100644
--- a/runtime/bin/vmservice/client/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart
@@ -27,7 +27,7 @@ abstract class ServiceObject extends Observable {
String _serviceType;
/// The complete service url of this object.
- @reflectable String get link => isolate.relativeLink(_id);
+ @reflectable String get link => _owner.relativeLink(_id);
/// The complete service url of this object with a '#/' prefix.
// TODO(turnidge): Figure out why using a getter here messes up polymer.
@@ -179,6 +179,7 @@ abstract class VM extends ServiceObjectOwner {
@reflectable Iterable<Isolate> get isolates => _isolateCache.values;
@reflectable String get link => '$id';
+ @reflectable String relativeLink(String id) => '$id';
@observable String version = 'unknown';
@observable String architecture = 'unknown';
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/vm_view.html ('k') | runtime/vm/flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698