Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2991393002: [standalone] Automatically decompress gzip'd resources, including sources and script snapshots. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[standalone] Automatically decompress gzip'd resources, including sources and script snapshots. Closes #30315 R=asiva@google.com, zra@google.com Committed: https://github.com/dart-lang/sdk/commit/7dfe62f70d0742c09733fdecd36a2e697c8cb190

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 6

Patch Set 4 : . #

Patch Set 5 : growth #

Patch Set 6 : Fix case in decompression where the snapshot it smaller than the chunk size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -105 lines) Patch
M runtime/bin/BUILD.gn View 1 5 chunks +12 lines, -1 line 0 comments Download
M runtime/bin/dartutils.h View 1 1 chunk +6 lines, -10 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 2 chunks +27 lines, -21 lines 0 comments Download
M runtime/bin/dfe.cc View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
A runtime/bin/gzip.h View 1 2 3 4 1 chunk +24 lines, -0 lines 0 comments Download
A runtime/bin/gzip.cc View 1 2 3 4 5 1 chunk +86 lines, -0 lines 0 comments Download
M runtime/bin/loader.cc View 1 4 chunks +41 lines, -2 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 2 chunks +2 lines, -66 lines 0 comments Download
M runtime/bin/snapshot_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
rmacnak
I'm not sure about this change. The decompression overhead is quite high. For the Flutter ...
3 years, 4 months ago (2017-08-03 22:00:34 UTC) #2
codefu
On 2017/08/03 22:00:34, rmacnak wrote: > I'm not sure about this change. The decompression overhead ...
3 years, 4 months ago (2017-08-03 22:05:35 UTC) #3
rmacnak
Adjusted the decompression to happen as needed at the loader level instead of specifically and ...
3 years, 4 months ago (2017-08-03 23:54:41 UTC) #6
zra
https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/gzip.cc File runtime/bin/gzip.cc (right): https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/gzip.cc#newcode61 runtime/bin/gzip.cc:61: *output = reinterpret_cast<uint8_t*>(realloc(*output, *output_length)); This is probably fine when ...
3 years, 4 months ago (2017-08-04 05:17:00 UTC) #7
siva
https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/dfe.cc File runtime/bin/dfe.cc (right): https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/dfe.cc#newcode149 runtime/bin/dfe.cc:149: if (DartUtils::SniffForMagicNumber(temp, *kernel_ir_size) != Now that SniffMagicNumber does not ...
3 years, 4 months ago (2017-08-04 17:11:29 UTC) #8
rmacnak
https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/dfe.cc File runtime/bin/dfe.cc (right): https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/dfe.cc#newcode149 runtime/bin/dfe.cc:149: if (DartUtils::SniffForMagicNumber(temp, *kernel_ir_size) != On 2017/08/04 17:11:29, siva wrote: ...
3 years, 4 months ago (2017-08-07 18:18:57 UTC) #9
rmacnak
On 2017/08/07 18:18:57, rmacnak wrote: > https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/dfe.cc > File runtime/bin/dfe.cc (right): > > https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/dfe.cc#newcode149 > ...
3 years, 4 months ago (2017-08-09 18:02:37 UTC) #10
siva
LGTM, I guess zra@ had a comment about the growth policy which may need to ...
3 years, 4 months ago (2017-08-09 18:12:33 UTC) #11
rmacnak
https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/gzip.cc File runtime/bin/gzip.cc (right): https://codereview.chromium.org/2991393002/diff/40001/runtime/bin/gzip.cc#newcode61 runtime/bin/gzip.cc:61: *output = reinterpret_cast<uint8_t*>(realloc(*output, *output_length)); On 2017/08/04 05:17:00, zra wrote: ...
3 years, 4 months ago (2017-08-10 21:09:09 UTC) #12
zra
lgtm
3 years, 4 months ago (2017-08-10 21:19:20 UTC) #13
rmacnak
Fixed case in decompression where the snapshot is smaller than the chunk size.
3 years, 4 months ago (2017-08-11 17:58:07 UTC) #14
rmacnak
3 years, 4 months ago (2017-08-11 19:18:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
7dfe62f70d0742c09733fdecd36a2e697c8cb190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698