Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: milo/api/resp/build.go

Issue 2991383002: Milo: Actually shorten step text (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/api/resp/build.go
diff --git a/milo/api/resp/build.go b/milo/api/resp/build.go
index 9c7e9685641a304801633ef64fcd1dfff70567e3..95f55b5fbbecdfb127931a0e0a2c2d43dffd2100 100644
--- a/milo/api/resp/build.go
+++ b/milo/api/resp/build.go
@@ -285,7 +285,7 @@ func NewLink(label, url string) *Link {
}
func (comp *BuildComponent) toModelSummary() model.Summary {
- text := comp.Text
+ text := strings.Join(comp.Text, "\n")
// Max length for a datastore text field is 1500 char, but for summary purposes
// we don't really need anything much longer than 256 char or so.
const maxTextLen = 256
@@ -302,7 +302,7 @@ func (comp *BuildComponent) toModelSummary() model.Summary {
Status: comp.Status,
Start: comp.Started,
End: comp.Finished,
- Text: text,
+ Text: strings.Split(text, "\n"),
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698