Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2991373002: double_round_to_double2 doesn't work on dart2js-safari. (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, bkonyi
CC:
dart2now-team_google.com, reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

double_round_to_double2 doesn't work on dart2js-safari. Fixes more bot breakage for block 7. BUG= R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/556fa63c2b367414f0abc9f070418a80a14653dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/corelib_2/corelib_2.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jcollins
More bot repair.
3 years, 4 months ago (2017-08-03 18:31:12 UTC) #2
jcollins
On 2017/08/03 18:31:12, jcollins wrote: > More bot repair. Specifically, this should fix this: https://build.chromium.org/p/client.dart/builders/dart2js-mac10.11-safari-1-3-be/builds/6088/steps/dart2js-safari-fast-startup%20tests/logs/stdio
3 years, 4 months ago (2017-08-03 18:31:42 UTC) #3
bkonyi
lgtm
3 years, 4 months ago (2017-08-03 19:22:32 UTC) #5
jcollins
3 years, 4 months ago (2017-08-03 20:02:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
556fa63c2b367414f0abc9f070418a80a14653dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698