Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2991363002: Migrated test block 14 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Migrated test block 14 to Dart 2.0. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2009 lines) Patch
M tests/corelib/corelib.status View 3 chunks +0 lines, -15 lines 0 comments Download
D tests/corelib/list_iterators_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/corelib/list_last_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib/list_literal_is_growable_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib/list_literal_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/corelib/list_map_test.dart View 1 1 chunk +0 lines, -164 lines 0 comments Download
D tests/corelib/list_remove_range_test.dart View 1 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib/list_removeat_test.dart View 1 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib/list_replace_range_test.dart View 1 1 chunk +0 lines, -123 lines 0 comments Download
D tests/corelib/list_reversed_test.dart View 1 1 chunk +0 lines, -136 lines 0 comments Download
D tests/corelib/list_set_all_test.dart View 1 1 chunk +0 lines, -103 lines 0 comments Download
D tests/corelib/list_set_range_test.dart View 1 1 chunk +0 lines, -120 lines 0 comments Download
D tests/corelib/list_sort_test.dart View 1 1 chunk +0 lines, -24 lines 0 comments Download
D tests/corelib/list_sublist_test.dart View 1 1 chunk +0 lines, -57 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 5 chunks +26 lines, -0 lines 0 comments Download
A + tests/corelib_2/list_iterators_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_last_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_literal_is_growable_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_literal_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_map_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_remove_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_removeat_test.dart View 1 1 chunk +0 lines, -8 lines 1 comment Download
A + tests/corelib_2/list_replace_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_reversed_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_set_all_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_set_range_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_sort_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_sublist_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib_strong/corelib_strong_kernel.status View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/corelib_strong/list_iterators_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/corelib_strong/list_last_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib_strong/list_literal_is_growable_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib_strong/list_literal_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/corelib_strong/list_map_test.dart View 1 chunk +0 lines, -164 lines 0 comments Download
D tests/corelib_strong/list_remove_range_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib_strong/list_removeat_test.dart View 1 chunk +0 lines, -82 lines 0 comments Download
D tests/corelib_strong/list_replace_range_test.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D tests/corelib_strong/list_reversed_test.dart View 1 chunk +0 lines, -136 lines 0 comments Download
D tests/corelib_strong/list_set_all_test.dart View 1 chunk +0 lines, -103 lines 0 comments Download
D tests/corelib_strong/list_set_range_test.dart View 1 chunk +0 lines, -120 lines 0 comments Download
D tests/corelib_strong/list_sort_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/corelib_strong/list_sublist_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-03 19:19:08 UTC) #2
Bob Nystrom
LGTM! https://codereview.chromium.org/2991363002/diff/20001/tests/corelib_2/list_removeat_test.dart File tests/corelib_2/list_removeat_test.dart (left): https://codereview.chromium.org/2991363002/diff/20001/tests/corelib_2/list_removeat_test.dart#oldcode42 tests/corelib_2/list_removeat_test.dart:42: "double"); Woo!
3 years, 4 months ago (2017-08-03 20:22:25 UTC) #3
bkonyi
3 years, 4 months ago (2017-08-03 20:47:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d7891cf58741e6bde6464b9a361320736ff39334.

Powered by Google App Engine
This is Rietveld 408576698