Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 299133002: New strings for the SSL overridable interstitial V2 (Closed)

Created:
6 years, 7 months ago by felt
Modified:
6 years, 7 months ago
Reviewers:
palmer
CC:
chromium-reviews, edwardjung
Visibility:
Public.

Description

New strings for the SSL overridable interstitial V2 BUG=331452 R=palmer@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272417

Patch Set 1 #

Patch Set 2 : Fixed missing end tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
felt
hey chris, can you please do a quickie review of these strings?
6 years, 7 months ago (2014-05-23 01:08:10 UTC) #1
felt
On 2014/05/23 01:08:10, felt wrote: > hey chris, can you please do a quickie review ...
6 years, 7 months ago (2014-05-23 01:11:32 UTC) #2
palmer
LGTM
6 years, 7 months ago (2014-05-23 01:19:12 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 7 months ago (2014-05-23 02:01:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/299133002/20001
6 years, 7 months ago (2014-05-23 02:03:15 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 06:58:35 UTC) #6
Message was sent while issue was closed. 
Change committed as 272417

Powered by Google App Engine
This is Rietveld 408576698