Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2991313003: Bot fixes: dynamic_nosuchmethod_test uses mirrors, disable when using fast_startup (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dynamic_nosuchmethod_test uses mirrors, disable when using fast_startup or precompiler. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/c2c93a00533d25ad9be4e18a8e000103cbbad48e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/corelib_2/corelib_2.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jcollins
This is from block 7.
3 years, 4 months ago (2017-08-03 18:07:56 UTC) #2
Bob Nystrom
lgtm
3 years, 4 months ago (2017-08-03 18:12:27 UTC) #3
jcollins
3 years, 4 months ago (2017-08-03 18:15:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2c93a00533d25ad9be4e18a8e000103cbbad48e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698