Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2991313002: Split ast based parts from InferrerEngineImpl (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -557 lines) Patch
A pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart View 1 chunk +530 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 4 chunks +15 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 19 chunks +43 lines, -525 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 3 chunks +41 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-03 13:51:29 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-08-03 21:10:38 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-04 07:57:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93d0a55534139438271258a65cfd8eac0e7c9e0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698