Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: milo/common/model/build_summary.go

Issue 2991243002: Milo: Console improvements (Closed)
Patch Set: Review comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « milo/common/config.go ('k') | milo/frontend/appengine/templates/pages/console.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The LUCI Authors. 1 // Copyright 2017 The LUCI Authors.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 // BuildKey will always point to the "real" build, i.e. a buildbotBuild or 53 // BuildKey will always point to the "real" build, i.e. a buildbotBuild or
54 // a buildbucketBuild. It is always the parent key for the BuildSummary. 54 // a buildbucketBuild. It is always the parent key for the BuildSummary.
55 BuildKey *datastore.Key `gae:"$parent"` 55 BuildKey *datastore.Key `gae:"$parent"`
56 56
57 // Global identifier for the builder that this Build belongs to, i.e.: 57 // Global identifier for the builder that this Build belongs to, i.e.:
58 // "buildbot/<mastername>/<buildername>" 58 // "buildbot/<mastername>/<buildername>"
59 // "buildbucket/<bucketname>/<buildername>" 59 // "buildbucket/<bucketname>/<buildername>"
60 BuilderID string 60 BuilderID string
61 61
62 // SelfLink provides a relative URL for this build.
63 // Buildbot: /buildbot/<mastername>/<buildername>/<buildnumber>
64 // Swarmbucket: Derived from Buildbucket (usually link to self)
65 SelfLink string
66
62 // Created is the time when the Build was first created. Due to pending 67 // Created is the time when the Build was first created. Due to pending
63 // queues, this may be substantially before Summary.Start. 68 // queues, this may be substantially before Summary.Start.
64 Created time.Time 69 Created time.Time
65 70
66 // Summary summarizes relevant bits about the overall build. 71 // Summary summarizes relevant bits about the overall build.
67 Summary Summary 72 Summary Summary
68 73
69 // CurrentStep summarizes relevant bits about the currently running step (if 74 // CurrentStep summarizes relevant bits about the currently running step (if
70 // any). Only expected to be set if !Summary.Status.Terminal(). 75 // any). Only expected to be set if !Summary.Status.Terminal().
71 CurrentStep Summary 76 CurrentStep Summary
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // the given parameters. 115 // the given parameters.
111 func NewPartialManifestKey(project, console, manifest, repoURL string) PartialMa nifestKey { 116 func NewPartialManifestKey(project, console, manifest, repoURL string) PartialMa nifestKey {
112 var buf bytes.Buffer 117 var buf bytes.Buffer
113 cmpbin.WriteUint(&buf, 0) // version 118 cmpbin.WriteUint(&buf, 0) // version
114 cmpbin.WriteString(&buf, project) 119 cmpbin.WriteString(&buf, project)
115 cmpbin.WriteString(&buf, console) 120 cmpbin.WriteString(&buf, console)
116 cmpbin.WriteString(&buf, manifest) 121 cmpbin.WriteString(&buf, manifest)
117 cmpbin.WriteString(&buf, repoURL) 122 cmpbin.WriteString(&buf, repoURL)
118 return PartialManifestKey(buf.Bytes()) 123 return PartialManifestKey(buf.Bytes())
119 } 124 }
OLDNEW
« no previous file with comments | « milo/common/config.go ('k') | milo/frontend/appengine/templates/pages/console.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698