Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 299123003: PrivetV2 SetupFlow, Session and SetupOperation interfaces (Closed)

Created:
6 years, 7 months ago by Noam Samuel
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

PrivetV2 SetupFlow, Session and SetupOperation interfaces This is a merged CL containing the PrivetV2SetupFlow, PrivetV2Session, and PrivetV2SetupOperation interfaces. BUG=372843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272647

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -5 lines) Patch
A chrome/browser/local_discovery/privetv2_session.h View 1 1 chunk +63 lines, -0 lines 0 comments Download
A + chrome/browser/local_discovery/privetv2_session.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
A chrome/browser/local_discovery/privetv2_setup_flow.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/privetv2_setup_flow.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/privetv2_setup_operation.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/local_discovery/privetv2_setup_operation.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Noam Samuel
6 years, 7 months ago (2014-05-23 17:14:57 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm BUG=372843
6 years, 7 months ago (2014-05-23 17:17:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/299123003/1
6 years, 7 months ago (2014-05-23 17:17:37 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/299123003/diff/1/chrome/browser/local_discovery/privetv2_session.h File chrome/browser/local_discovery/privetv2_session.h (right): https://codereview.chromium.org/299123003/diff/1/chrome/browser/local_discovery/privetv2_session.h#newcode31 chrome/browser/local_discovery/privetv2_session.h:31: const std::string& confirmation_code, callbacks should be in Delegate scope ...
6 years, 7 months ago (2014-05-23 17:22:09 UTC) #4
Noam Samuel
https://codereview.chromium.org/299123003/diff/1/chrome/browser/local_discovery/privetv2_session.h File chrome/browser/local_discovery/privetv2_session.h (right): https://codereview.chromium.org/299123003/diff/1/chrome/browser/local_discovery/privetv2_session.h#newcode31 chrome/browser/local_discovery/privetv2_session.h:31: const std::string& confirmation_code, On 2014/05/23 17:22:09, Vitaly Buka wrote: ...
6 years, 7 months ago (2014-05-23 17:30:09 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 7 months ago (2014-05-23 17:32:28 UTC) #6
Noam Samuel
On 2014/05/23 17:32:28, Vitaly Buka wrote: > lgtm Added changes from https://codereview.chromium.org/284323005/
6 years, 7 months ago (2014-05-23 19:42:35 UTC) #7
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 7 months ago (2014-05-23 19:42:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/299123003/40001
6 years, 7 months ago (2014-05-23 19:43:56 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 22:52:53 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:07:21 UTC) #11
Message was sent while issue was closed.
Change committed as 272647

Powered by Google App Engine
This is Rietveld 408576698