Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile_table.dart

Issue 2991203002: Fix Observatory virtual-collection layout issues (Closed)
Patch Set: Fix persistent handles page Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/cpu_profile_table.dart
diff --git a/runtime/observatory/lib/src/elements/cpu_profile_table.dart b/runtime/observatory/lib/src/elements/cpu_profile_table.dart
index 7c34d1b5c0709521de9fd6b161814e6fe4c7b738..0cb40f7dc22ad9c74cc26b2b4185e73c68462875 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile_table.dart
+++ b/runtime/observatory/lib/src/elements/cpu_profile_table.dart
@@ -229,16 +229,26 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
..classes = ['name'];
}
- Element _createFunctionHeader() => new DivElement()
- ..classes = ['function-item']
- ..children = [
- _createHeaderButton(const ['exclusive'], 'Execution(%)', _Table.functions,
- _SortingField.exclusive, _SortingDirection.descending),
- _createHeaderButton(const ['inclusive'], 'Stack(%)', _Table.functions,
- _SortingField.inclusive, _SortingDirection.descending),
- _createHeaderButton(const ['name'], 'Method', _Table.functions,
- _SortingField.method, _SortingDirection.ascending),
- ];
+ List<HtmlElement> _createFunctionHeader() => [
+ new DivElement()
+ ..classes = ['function-item']
+ ..children = [
+ _createHeaderButton(
+ const ['exclusive'],
+ 'Execution(%)',
+ _Table.functions,
+ _SortingField.exclusive,
+ _SortingDirection.descending),
+ _createHeaderButton(
+ const ['inclusive'],
+ 'Stack(%)',
+ _Table.functions,
+ _SortingField.inclusive,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['name'], 'Method', _Table.functions,
+ _SortingField.method, _SortingDirection.ascending),
+ ]
+ ];
void _setSorting(
_Table table, _SortingField field, _SortingDirection defaultDirection) {
@@ -284,14 +294,20 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
..classes = ['name'];
}
- Element _createCalleeHeader() => new DivElement()
- ..classes = ['function-item']
- ..children = [
- _createHeaderButton(const ['inclusive'], 'Callees(%)', _Table.callee,
- _SortingField.callee, _SortingDirection.descending),
- _createHeaderButton(const ['name'], 'Method', _Table.callee,
- _SortingField.method, _SortingDirection.ascending),
- ];
+ List<HtmlElement> _createCalleeHeader() => [
+ new DivElement()
+ ..classes = ['function-item']
+ ..children = [
+ _createHeaderButton(
+ const ['inclusive'],
+ 'Callees(%)',
+ _Table.callee,
+ _SortingField.callee,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['name'], 'Method', _Table.callee,
+ _SortingField.method, _SortingDirection.ascending),
+ ]
+ ];
Element _createCaller() {
final element = new DivElement()
@@ -319,14 +335,20 @@ class CpuProfileTableElement extends HtmlElement implements Renderable {
..classes = ['name'];
}
- Element _createCallerHeader() => new DivElement()
- ..classes = ['function-item']
- ..children = [
- _createHeaderButton(const ['inclusive'], 'Callers(%)', _Table.caller,
- _SortingField.caller, _SortingDirection.descending),
- _createHeaderButton(const ['name'], 'Method', _Table.caller,
- _SortingField.method, _SortingDirection.ascending),
- ];
+ List<HtmlElement> _createCallerHeader() => [
+ new DivElement()
+ ..classes = ['function-item']
+ ..children = [
+ _createHeaderButton(
+ const ['inclusive'],
+ 'Callers(%)',
+ _Table.caller,
+ _SortingField.caller,
+ _SortingDirection.descending),
+ _createHeaderButton(const ['name'], 'Method', _Table.caller,
+ _SortingField.method, _SortingDirection.ascending),
+ ]
+ ];
ButtonElement _createHeaderButton(List<String> classes, String text,
_Table table, _SortingField field, _SortingDirection direction) =>

Powered by Google App Engine
This is Rietveld 408576698