Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2991183002: Fix Observatory double connection in clean browser (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, rmacnak, siva
CC:
reviews_dartlang.org, rmacnak, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Observatory double connection in clean browser If the local storage of the browser is empty observatory connects two times to the Service Protocol having as side effect the redirection to the `/vm` page Closes https://github.com/dart-lang/sdk/issues/30312 R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/acfd8a9f81ea2035912a4f3f028ecbf7bb9dcee4

Patch Set 1 #

Patch Set 2 : Fix variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M runtime/observatory/lib/src/repositories/target.dart View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
cbernaschina
3 years, 4 months ago (2017-08-01 21:16:17 UTC) #2
cbernaschina
Better variable names connection => target
3 years, 4 months ago (2017-08-01 21:31:05 UTC) #4
bkonyi
LGTM
3 years, 4 months ago (2017-08-01 21:33:44 UTC) #5
cbernaschina
3 years, 4 months ago (2017-08-01 21:36:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
acfd8a9f81ea2035912a4f3f028ecbf7bb9dcee4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698