Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 299113003: Add win8.1 support to GPUBotConfig (Closed)

Created:
6 years, 7 months ago by Zhenyao Mo
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Add win8.1 support to GPUBotConfig Also add some error message in case LoadCurrentConfig fails. BUG= TEST=gpu_unittests R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272488

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M gpu/config/gpu_info_collector_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_info_collector_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_test_config.cc View 3 chunks +5 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Zhenyao Mo
kbr: please take a look.
6 years, 7 months ago (2014-05-23 00:50:09 UTC) #1
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/299113003/diff/1/gpu/config/gpu_test_config.cc File gpu/config/gpu_test_config.cc (right): https://codereview.chromium.org/299113003/diff/1/gpu/config/gpu_test_config.cc#newcode41 gpu/config/gpu_test_config.cc:41: return GPUTestConfig::kOsWin8; We might need to add a ...
6 years, 7 months ago (2014-05-23 02:37:58 UTC) #2
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 7 months ago (2014-05-23 02:53:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/299113003/1
6 years, 7 months ago (2014-05-23 02:55:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 04:49:17 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:08:55 UTC) #6
Message was sent while issue was closed.
Change committed as 272488

Powered by Google App Engine
This is Rietveld 408576698