Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2991073002: remove unittest as a test status, instead record this at test build time (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly
Modified:
3 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove unittest as a test status, instead record this at test build time this will help integrate with existing .status files R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/925295d7affe5abc8bc36f0c15c563c558d53e08

Patch Set 1 #

Patch Set 2 : cleanup import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -40 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 9 chunks +7 lines, -28 lines 0 comments Download
M pkg/dev_compiler/test/codegen_test.dart View 1 4 chunks +27 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 4 months ago (2017-07-29 01:52:54 UTC) #2
vsm
lgtm
3 years, 4 months ago (2017-07-31 20:57:10 UTC) #3
Jennifer Messerly
3 years, 4 months ago (2017-07-31 21:25:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
925295d7affe5abc8bc36f0c15c563c558d53e08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698