Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2991063002: fix DDC travis bot (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix DDC travis bot It appears to have been broken by the language_2 test migration. Committed: https://github.com/dart-lang/sdk/commit/951e9a5f88922b4196f98e6f26ff38caeb2599a7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/test-main.js View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 3 chunks +3 lines, -0 lines 1 comment Download
M pkg/dev_compiler/test/compile_error_tests.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
TBR https://codereview.chromium.org/2991063002/diff/1/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2991063002/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode275 pkg/dev_compiler/test/browser/language_tests.js:275: 'list_sort_test': fail, // runtime strong mode error this ...
3 years, 4 months ago (2017-07-29 00:04:06 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as 951e9a5f88922b4196f98e6f26ff38caeb2599a7 (presubmit successful).
3 years, 4 months ago (2017-07-29 00:04:46 UTC) #5
Bob Nystrom
3 years, 4 months ago (2017-07-31 20:52:37 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698