config_service: Added revision and timestamp to config-set-cards and config-set pages

appengine/config_service/ui/src/config-ui/config-set-card.html

Index: appengine/config_service/ui/src/config-ui/config-set-card.html
diff --git a/appengine/config_service/ui/src/config-ui/config-set-card.html b/appengine/config_service/ui/src/config-ui/config-set-card.html
index 8bff3bc1e0c786cf30efd68aabcce2bb91dd7dd5..aa352f65226ae24d1de250e78732b653e3ad1fdd 100644
--- a/appengine/config_service/ui/src/config-ui/config-set-card.html
+++ b/appengine/config_service/ui/src/config-ui/config-set-card.html
@@ -11,6 +11,7 @@
 <link rel="import" href="../../bower_components/iron-icons/maps-icons.html">
 <link rel="import" href="../../bower_components/iron-flex-layout/iron-flex-layout.html">
 <link rel="import" href="../../bower_components/paper-tooltip/paper-tooltip.html">
+<link rel="import" href="../../common/common-behaviors.html">
 
 <dom-module id="config-set-card">
   <template>
@@ -53,8 +54,17 @@
     <a href="#/[[name]]">
       <paper-card elevation="2">
         <div class="card-content">
-          <div class="config-title">[[name]]
+          <div class="config-title">
+            [[name]]
             <div class="validation">
+              <iron-icon id="launch"
+                         icon="icons:launch"
+                         class="paper-grey"
+                         on-tap="_openConfig">

[Sergey Berezin, 2017/07/31 20:21:18]

This correctly opens a new window, but also opens the original page on the
config set (probably because it's click on the entire card). I'd expect the
original page to stay unchanged.

Perhaps, we should change the clickable surface inside the card to exclude the
external link.

[cwpayton, 2017/07/31 23:40:53]

Done.

+              </iron-icon>
+              <paper-tooltip for="launch" offset="0">
+                [[link]]
+              </paper-tooltip>
               <template is="dom-if" if="[[lastImportAttempt]]" restamp="true">
                 <template is="dom-if" if="[[lastImportAttempt.success]]" restamp="true">
                   <iron-icon id="successful-import" 
@@ -85,6 +95,8 @@
                 </paper-tooltip>
               </template>
             </div>
+            <p>Revision: [[revision]]</p>
+            <p>Timestamp: [[timestamp]]</p>

[Sergey Berezin, 2017/07/31 20:21:18]

I'd make this more compact:
- Print only the fist 7 digits of the revision (similar to git short hash)
- Place the date on the same line, possibly shortened e.g. to "x
min/hours/days/.. ago" with a bubble showing the actual date, similar to how
Rietveld and Monorail do it.

In fact, if the revision / date fit on the same line as the project title, I'd
try doing that too. It should be possible to let HTML format it dynamically if
the card is wide enough, and otherwise wrap it to the next line.

[cwpayton, 2017/07/31 23:40:53]

Done.

           </div>
         </div>
       </paper-card>
@@ -95,20 +107,11 @@
     Polymer({
       is: "config-set-card",
 
-      properties: {
-        name: {
-          type: String
-        },
-
-        lastImportAttempt: {
-          type: Object
-        },
-      },
-
-      _not: function(b) {
-        return !b;
-      },
+      behaviors: [ConfigUIBehaviors.CommonBehavior],
 
+      _openConfig: function() {
+        window.open(this.link);
+      }
     });
   </script>
 </dom-module>