Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: appengine/config_service/ui/test/config-ui/config-set_test.html

Issue 2991013002: config_service: Added revision and timestamp to config-set-cards and config-set pages (Closed)
Patch Set: Refactored test to give each function its own suite Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/config_service/ui/test/config-ui/config-set_test.html
diff --git a/appengine/config_service/ui/test/config-ui/config-set_test.html b/appengine/config_service/ui/test/config-ui/config-set_test.html
index 6da47e8d9d412b3ef2d9518ebe8ea9324d7c061d..71ed52d0b7522dd064c06614d22d243b3d9becd3 100644
--- a/appengine/config_service/ui/test/config-ui/config-set_test.html
+++ b/appengine/config_service/ui/test/config-ui/config-set_test.html
@@ -70,7 +70,7 @@
assert.equal(config_set.category, 'projects');
});
- test('has correct name', function() {
+ test('has correct name', function() {
assert.equal(config_set.name, 'valid-project-with-config-files');
});
@@ -82,7 +82,13 @@
var param = {
config_sets: [{
files: [{path: "OWNERS"}, {path: "README.md"}],
- last_import_attempt: { success: true },
+ last_import_attempt: {
+ success: true,
+ revision: {
+ url: "https://test.com",
+ timestamp: "1234567890"
+ }
+ }
}]
};
setserver(param);
@@ -239,7 +245,7 @@
assert.equal(request.status, 204);
config_set.addEventListener('refreshComplete', function() {
assert.equal(config_set.isRefreshing, false);
- assert.equal(config_set.refreshMessage, "Refresh successful.");
+ assert.equal(config_set.refreshMessage, "Reimport successful.");
done();
}.bind(config_set));
});
@@ -290,7 +296,7 @@
assert.equal(request.status, 404);
config_set.addEventListener('refreshError', function() {
assert.equal(config_set.isRefreshing, false);
- assert.equal(config_set.refreshMessage, "Error: Files could not be refreshed.");
+ assert.equal(config_set.refreshMessage, "Error: Files could not be reimported.");
done();
}.bind(config_set));
});
« no previous file with comments | « appengine/config_service/ui/test/common/common-behaviors_test.html ('k') | appengine/config_service/ui/test/index.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698