Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: appengine/config_service/ui/src/config-ui/config-set-card.html

Issue 2991013002: config_service: Added revision and timestamp to config-set-cards and config-set pages (Closed)
Patch Set: Refactored test to give each function its own suite Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/config_service/ui/src/config-ui/config-set-card.html
diff --git a/appengine/config_service/ui/src/config-ui/config-set-card.html b/appengine/config_service/ui/src/config-ui/config-set-card.html
index 8bff3bc1e0c786cf30efd68aabcce2bb91dd7dd5..e58ad245bbde38e144ce568df4fc1abc5c0ed262 100644
--- a/appengine/config_service/ui/src/config-ui/config-set-card.html
+++ b/appengine/config_service/ui/src/config-ui/config-set-card.html
@@ -11,20 +11,16 @@
<link rel="import" href="../../bower_components/iron-icons/maps-icons.html">
<link rel="import" href="../../bower_components/iron-flex-layout/iron-flex-layout.html">
<link rel="import" href="../../bower_components/paper-tooltip/paper-tooltip.html">
+<link rel="import" href="../../common/common-behaviors.html">
<dom-module id="config-set-card">
<template>
<style>
- a {
- text-decoration: none;
- color: inherit;
- }
-
paper-card {
width: 100%;
}
- p {
+ span {
color: var(--paper-grey-600);
word-wrap: break-word;
font-size: 90%;
@@ -50,65 +46,79 @@
</style>
- <a href="#/[[name]]">
- <paper-card elevation="2">
- <div class="card-content">
- <div class="config-title">[[name]]
- <div class="validation">
- <template is="dom-if" if="[[lastImportAttempt]]" restamp="true">
- <template is="dom-if" if="[[lastImportAttempt.success]]" restamp="true">
- <iron-icon id="successful-import"
- icon="icons:check-circle"
- class="paper-green">
- </iron-icon>
- <paper-tooltip for="successful-import" offset="0">
- Last import succeeded.
- </paper-tooltip>
- </template>
- <template is="dom-if" if="[[_not(lastImportAttempt.success)]]" restamp="true">
- <iron-icon id="failed-import"
- icon="icons:warning"
- class="paper-red">
- </iron-icon>
- <paper-tooltip for="failed-import" offset="0">
- Last import failed.
- </paper-tooltip>
- </template>
+ <paper-card elevation="2"
+ on-tap="_openConfigPage">
+ <div class="card-content">
+ <div class="config-title">
+ [[name]]
+ <div class="validation">
+ <iron-icon id="launch"
+ icon="icons:launch"
+ class="paper-grey"
+ on-tap="_openConfigGitiles">
+ </iron-icon>
+ <paper-tooltip for="launch" offset="0">
+ [[link]]
+ </paper-tooltip>
+ <template is="dom-if" if="[[lastImportAttempt]]" restamp="true">
+ <template is="dom-if" if="[[lastImportAttempt.success]]" restamp="true">
+ <iron-icon id="successful-import"
+ icon="icons:check-circle"
+ class="paper-green">
+ </iron-icon>
+ <paper-tooltip for="successful-import" offset="0">
+ Last import succeeded.
+ </paper-tooltip>
</template>
- <template is="dom-if" if="[[_not(lastImportAttempt)]]" restamp="true">
- <iron-icon id="no-import"
- icon="icons:help"
- class="paper-grey">
+ <template is="dom-if" if="[[_not(lastImportAttempt.success)]]" restamp="true">
+ <iron-icon id="failed-import"
+ icon="icons:warning"
+ class="paper-red">
</iron-icon>
- <paper-tooltip for="no-import" offset="0">
- Last import attempt info not available.
+ <paper-tooltip for="failed-import" offset="0">
+ Last import failed.
</paper-tooltip>
</template>
- </div>
+ </template>
+ <template is="dom-if" if="[[_not(lastImportAttempt)]]" restamp="true">
+ <iron-icon id="no-import"
+ icon="icons:help"
+ class="paper-grey">
+ </iron-icon>
+ <paper-tooltip for="no-import" offset="0">
+ Last import attempt info not available.
+ </paper-tooltip>
+ </template>
+ </div>
+ <div>
+ <span id="revision">Revision: [[_formatRevision(revision)]]</span>
+ <paper-tooltip for="revision" offset="0">
+ [[revision]]
+ </paper-tooltip>
+ <span id="timestamp">Timestamp: [[_formatDate(timestamp)]]</span>
+ <paper-tooltip for="timestamp" offset="0">
+ [[_getExactTime(timestamp)]]
+ </paper-tooltip>
</div>
</div>
- </paper-card>
- </a>
+ </div>
+ </paper-card>
</template>
<script>
Polymer({
is: "config-set-card",
- properties: {
- name: {
- type: String
- },
+ behaviors: [ConfigUIBehaviors.CommonBehavior],
- lastImportAttempt: {
- type: Object
- },
+ _openConfigGitiles: function(event) {
+ event.stopPropagation();
+ window.open(this.link);
},
- _not: function(b) {
- return !b;
+ _openConfigPage: function() {
+ window.location.href = window.location.href + this.name;
},
-
});
</script>
</dom-module>
« no previous file with comments | « appengine/config_service/ui/src/config-ui/config-set.html ('k') | appengine/config_service/ui/src/config-ui/config-ui.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698