config_service: Added revision and timestamp to config-set-cards and config-set pages

appengine/config_service/ui/src/config-ui/config-set.html

 <!--
   Copyright 2017 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 -->
 
 <link rel="import" href="config-file-card.html">
 <link rel="import" href="../../bower_components/iron-ajax/iron-ajax.html">
 <link rel="import" href="../../bower_components/iron-icons/iron-icons.html">
 <link rel="import" href="../../bower_components/paper-item/paper-item.html">
 <link rel="import" href="../../bower_components/paper-spinner/paper-spinner.html">
 <link rel="import" href="../../bower_components/polymer/polymer.html">
 <link rel="import" href="../../bower_components/iron-icons/maps-icons.html">
 <link rel="import" href="../../bower_components/paper-tooltip/paper-tooltip.html">
+<link rel="import" href="../../common/common-behaviors.html">
 
 <dom-module id="config-set">
   <template>
     <style>
       @media only screen and (min-width: 768px) {
         .center {
           width: 550px;
         }
       }
 
+      a {
+        text-decoration: none;
+        color: inherit;
+      }
+
       .category {
         font-size: 100%;
         font-family: sans-serif;
       }
 
       .name {
         font-size: 200%;
         font-family: sans-serif;
         word-wrap: break-word;
       }
@@ skipping 48 matching lines @@
         handle-as="json"
         on-error="_onRefreshError"
         on-response="_onCompleteRefresh"
         headers="[[auth_headers]]">
     </iron-ajax>
 
     <div class="center title"> 
       <div class="name">
         [[name]][[route.path]]
         <template is="dom-if" if="[[_not(isLoading)]]">
+          <a href="[[url]]">
+            <iron-icon id="launch"
+                       icon="icons:launch"
+                       class="paper-grey">
+            </iron-icon>
+            <paper-tooltip for="launch" offset="0">
+              [[url]]
+            </paper-tooltip>
+          </a>
           <template is="dom-if" if="[[lastImportAttempt]]">
             <template is="dom-if" if="[[lastImportAttempt.success]]">
               <iron-icon id="valid" icon="icons:check-circle" class="paper-green"></iron-icon>
             </template>
             <template is="dom-if" if="[[_not(lastImportAttempt.success)]]">
               <iron-icon id="invalid" icon="icons:warning" class="paper-red"></iron-icon>
             </template>
           </template>
           <template is="dom-if" if="[[_not(lastImportAttempt)]]">
             <iron-icon icon="icons:help" class="paper-grey"></iron-icon>
@@ skipping 16 matching lines @@
             <template is="dom-if" if="[[_not(lastImportAttempt.success)]]">
               Last import attempt failed: [[lastImportAttempt.message]]
             </template>
             <template is="dom-if" if="[[lastImportAttempt.success]]">
               Last import succeeded.
             </template>
           </template>
           <template is="dom-if" if="[[_not(lastImportAttempt)]]">
             Last import attempt info not available.
           </template>
+          <p>Revision: [[_getRevision(revision)]]</p>

[Sergey Berezin, 2017/07/31 20:21:18]

I'd try to fit it all in one line, see comment in config-set-card.html. The
timestamp can remain absolute though, since we have more space here.

[cwpayton, 2017/07/31 23:40:53]

Done.

+          <p>Timestamp: [[_getTimestamp(lastImportAttempt, revision)]]</p>
         </template>
         <p id="refreshStatus">[[refreshMessage]]</p>
       </div>      
     </div>
     <template is="dom-if" if="[[_not(errorMessage)]]">
       <template is="dom-if" if="[[isRefreshing]]">
         <div class="spinner">
           <paper-spinner active></paper-spinner>
         </div>
       </template>
@@ skipping 24 matching lines @@
     <template is="dom-if" if="[[errorMessage]]">
       <div class="center">
         <p>[[errorMessage]]</p>
       </div>
     </template>
   </template>
   <script>
     Polymer({
       is: "config-set",
 
+      behaviors: [ConfigUIBehaviors.CommonBehavior],
+
       properties: {
         frontPageIsActive: {
           type: Boolean,
           observer: '_frontPageIsActive'
         },
 
         category: {
           type: String
         },
 
@@ skipping 21 matching lines @@
 
         name: {
           type: String
         },
 
         refreshMessage: {
           type: String,
           value: null
         },
 
+        revision: {
+          type: String,
+          value: null
+        },
+
         errorMessage: {
           type: String,
           value: null
         }
       },
 
       _forceRefresh: function() {
         this.refreshMessage = null;
         this.$.refreshConfigs.generateRequest();
         this.isRefreshing = true;
       },
 
-      _frontPageIsActive: function() {
-        if (this.frontPageIsActive === false) {
-          this.isLoading = true;
-          if (!this.initialized) {
-            document.addEventListener('fetch-configs', function() {
-              this.$.requestConfigs.generateRequest();
-            }.bind(this));
-          } else {
-            this.$.requestConfigs.generateRequest();
-          }
-        }
-      },
-
-      _isEmpty: function(list) {
-        return list.length === 0;
-      },
-
       _formatCategory: function(category) {
         if (category === "projects") return "Project";
         if (category === "services") return "Service";
       },
 
       _onCompleteRefresh: function() {
         this.isRefreshing = false;
         this.refreshMessage = "Refresh successful.";
         this.fire('refreshComplete');
       },
 
-      _not: function(b) {
-        return !b;
-      },
-
       _onGotConfigFiles: function(event) {
         var config_set = event.detail.response.config_sets[0];
         this.files = config_set.files || [];
         this.lastImportAttempt = config_set.last_import_attempt || null;
-        if (config_set.revision && config_set.revision.url) {
-          this.url = config_set.revision.url;
+        if (this.lastImportAttempt && this.lastImportAttempt.success) {
+          this.url = config_set.last_import_attempt.revision.url;
+          this.revision = config_set.last_import_attempt.revision;
+        } else if (config_set.revision) {
+          this.url = config_set.revision.url || config_set.location;
+          this.revision = config_set.revision;
         } else {
           this.url = config_set.location;
         }
         this.isLoading = false;
         this.errorMessage = null;
         this.fire('processedConfigFiles');
       },
 
       _onRefreshError: function() {
         this.isRefreshing = false;
@@ skipping 16 matching lines @@
           this.errorMessage = "Internal server error.";
         } else {
           this.errorMessage = "Error occured. Try again later.";
         }
         this.fire('fetchError');
       }
 
     });
   </script>
 </dom-module>