Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990983002: Handle NativeTypedArray in closed_world_from_dill_test (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle NativeTypedArray in closed_world_from_dill_test - includes using the optimized mixin algorithm - includes computing the default super class for natives R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/925948717432f4b4436f60d9539930fd7e308395

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -20 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -0 lines 1 comment Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 5 chunks +19 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_from_dill_test.dart View 4 chunks +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-07-28 18:04:35 UTC) #2
Johnni Winther
https://codereview.chromium.org/2990983002/diff/1/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/2990983002/diff/1/pkg/compiler/lib/src/elements/modelx.dart#newcode1949 pkg/compiler/lib/src/elements/modelx.dart:1949: // ignore: strong_mode_invalid_method_override_from_base Not sure why this error suddenly ...
3 years, 4 months ago (2017-07-28 18:06:02 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-07-28 18:27:17 UTC) #4
Johnni Winther
3 years, 4 months ago (2017-07-28 19:06:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
925948717432f4b4436f60d9539930fd7e308395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698