Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2990933002: Migrate block 43. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update tests and status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -2018 lines) Patch
D tests/language/bad_constructor_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language/bad_initializer1_negative_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/bad_initializer2_negative_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language/bad_named_constructor_negative_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/bad_named_parameters2_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/bad_named_parameters_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D tests/language/bad_override_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language/bad_raw_string_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language/bad_typedef_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language/bailout2_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language/bailout3_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/language/bailout4_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/language/bailout5_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/language/bailout6_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language/bailout7_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/language/bailout_container_type_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language/bailout_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/language/bind_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language/bit_operations_test.dart View 1 chunk +0 lines, -218 lines 0 comments Download
D tests/language/bit_shift_test.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D tests/language/black_listed_test.dart View 1 chunk +0 lines, -137 lines 0 comments Download
D tests/language/body_less_constructor_wrong_arg_negative_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 3 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 7 chunks +0 lines, -47 lines 0 comments Download
A + tests/language_2/bad_constructor_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language_2/bad_initializer1_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bad_initializer2_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bad_named_constructor_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bad_named_parameters2_test.dart View 1 1 chunk +4 lines, -18 lines 0 comments Download
A tests/language_2/bad_named_parameters_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A + tests/language_2/bad_override_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/language_2/bad_raw_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bad_typedef_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_2/bailout2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout6_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout7_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout_container_type_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bailout_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bind_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/bit_operations_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/language_2/bit_shift_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/black_listed_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/body_less_constructor_wrong_arg_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_2/language_2.status View 1 13 chunks +155 lines, -4 lines 0 comments Download
D tests/language_strong/bad_constructor_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_strong/bad_initializer1_negative_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language_strong/bad_initializer2_negative_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language_strong/bad_named_constructor_negative_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language_strong/bad_named_parameters2_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language_strong/bad_named_parameters_test.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D tests/language_strong/bad_override_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language_strong/bad_raw_string_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language_strong/bailout2_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language_strong/bailout3_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/language_strong/bailout4_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/language_strong/bailout5_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/language_strong/bailout6_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language_strong/bailout7_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/language_strong/bailout_container_type_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/language_strong/bailout_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/language_strong/bind_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language_strong/bit_operations_test.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D tests/language_strong/bit_shift_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/language_strong/black_listed_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/language_strong/body_less_constructor_wrong_arg_negative_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/language_strong/language_strong.status View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bob Nystrom
3 years, 4 months ago (2017-07-28 02:02:57 UTC) #2
bkonyi
Just wondering, do we want to be merging the contents of all the various language_*.status ...
3 years, 4 months ago (2017-07-28 18:33:01 UTC) #3
Bob Nystrom
On 2017/07/28 18:33:01, bkonyi wrote: > Just wondering, do we want to be merging the ...
3 years, 4 months ago (2017-07-28 20:25:36 UTC) #4
bkonyi
Okay, makes sense. Also, just found a copyright date that you might want to update. ...
3 years, 4 months ago (2017-07-28 20:30:41 UTC) #5
Bob Nystrom
On 2017/07/28 20:30:41, bkonyi wrote: > Okay, makes sense. Also, just found a copyright date ...
3 years, 4 months ago (2017-07-28 21:33:07 UTC) #6
Bob Nystrom
3 years, 4 months ago (2017-08-01 23:58:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3c7f9852a553426603d2b6fc0bb61c07c6136727.

Powered by Google App Engine
This is Rietveld 408576698