Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2990913002: Updated observatory_pub_packages dependency (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva, kevmoo
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update observatory_pub_packages dependency Updated all observatory dependencies. In particular charted to 0.4.8 R=rmacnak@google.com TBR=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a67d798841ec6379c39c6cd20e9b867689df0e64

Patch Set 1 #

Patch Set 2 : Removed reference to observable #

Patch Set 3 : Remove reference to old observatory dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -105 lines) Patch
M .packages View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/.packages View 3 chunks +7 lines, -8 lines 0 comments Download
M runtime/observatory/lib/tracer.dart View 1 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/pubspec.lock View 2 chunks +63 lines, -69 lines 0 comments Download
M runtime/observatory/pubspec.yaml View 5 chunks +17 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
cbernaschina
3 years, 4 months ago (2017-07-27 22:06:01 UTC) #2
kevmoo
Take a look here https://github.com/dart-lang/sdk/blob/master/.packages smoke and observe are referenced into the observatory packages I ...
3 years, 4 months ago (2017-07-28 00:06:03 UTC) #4
cbernaschina
Thank you @kevmoo I'm checking it
3 years, 4 months ago (2017-07-28 00:18:36 UTC) #5
rmacnak
lgtm
3 years, 4 months ago (2017-07-28 17:38:15 UTC) #6
cbernaschina
Right now the bots are Red, but it looks like that the tests that are ...
3 years, 4 months ago (2017-07-28 20:19:30 UTC) #7
cbernaschina
3 years, 4 months ago (2017-07-31 20:03:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a67d798841ec6379c39c6cd20e9b867689df0e64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698