Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990903002: Migrated test block 16 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 16 to Dart 2.0. Lots of issues in map_test caused by the use of conflicting key types. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/f50a3068754a414e4331bea11e5ec9080a399f5b

Patch Set 1 #

Patch Set 2 : Migrated test block 16 to Dart 2.0. #

Total comments: 1

Patch Set 3 : Changed useIntegerKeys to a named parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2988 lines) Patch
M tests/corelib/corelib.status View 1 5 chunks +0 lines, -16 lines 0 comments Download
D tests/corelib/main_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib/map_contains_key_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib/map_contains_value_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib/map_from_iterable_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib/map_from_iterables_test.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/corelib/map_from_test.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D tests/corelib/map_index_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib/map_keys2_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib/map_keys_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib/map_remove_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib/map_test.dart View 1 1 chunk +0 lines, -974 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 5 chunks +21 lines, -0 lines 0 comments Download
A + tests/corelib_2/main_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_contains_key_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_contains_value_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_from_iterable_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_from_iterables_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_from_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_index_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_keys2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_keys_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_remove_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_test.dart View 1 2 11 chunks +32 lines, -38 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tests/corelib_strong/corelib_strong_kernel.status View 1 1 chunk +0 lines, -1 line 0 comments Download
D tests/corelib_strong/main_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/corelib_strong/map_contains_key_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib_strong/map_contains_value_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib_strong/map_from_iterable_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/corelib_strong/map_from_iterables_test.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D tests/corelib_strong/map_from_test.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D tests/corelib_strong/map_index_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib_strong/map_keys2_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/corelib_strong/map_keys_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib_strong/map_remove_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/corelib_strong/map_test.dart View 1 chunk +0 lines, -984 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bkonyi
3 years, 4 months ago (2017-07-31 20:22:28 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/2990903002/diff/20001/tests/corelib_2/map_test.dart File tests/corelib_2/map_test.dart (right): https://codereview.chromium.org/2990903002/diff/20001/tests/corelib_2/map_test.dart#newcode128 tests/corelib_2/map_test.dart:128: void test(Map map, [bool useIntegerKeys = true]) { ...
3 years, 4 months ago (2017-07-31 21:19:16 UTC) #4
bkonyi
3 years, 4 months ago (2017-07-31 22:08:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f50a3068754a414e4331bea11e5ec9080a399f5b.

Powered by Google App Engine
This is Rietveld 408576698