Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: packages/usage/test/src/common.dart

Issue 2990843002: Removed fixed dependencies (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/usage/test/hit_types_test.dart ('k') | packages/usage/test/usage_impl_io_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/usage/test/src/common.dart
diff --git a/packages/usage/test/src/common.dart b/packages/usage/test/src/common.dart
index 77993942ff9495da65073672284d41252f78e1cd..238ce6db1bbe9b0b74b1205751db3d39442fea27 100644
--- a/packages/usage/test/src/common.dart
+++ b/packages/usage/test/src/common.dart
@@ -9,20 +9,22 @@ import 'dart:async';
import 'package:test/test.dart';
import 'package:usage/src/usage_impl.dart';
-AnalyticsImplMock createMock({Map<String, dynamic> props}) =>
- new AnalyticsImplMock('UA-0', props: props);
+AnalyticsImplMock createMock({bool setOptIn: true}) =>
+ new AnalyticsImplMock('UA-0', setOptIn: setOptIn);
-was(Map m, String type) => expect(m['t'], type);
-has(Map m, String key) => expect(m[key], isNotNull);
-hasnt(Map m, String key) => expect(m[key], isNull);
+void was(Map m, String type) => expect(m['t'], type);
+void has(Map m, String key) => expect(m[key], isNotNull);
+void hasnt(Map m, String key) => expect(m[key], isNull);
class AnalyticsImplMock extends AnalyticsImpl {
MockProperties get mockProperties => properties;
MockPostHandler get mockPostHandler => postHandler;
- AnalyticsImplMock(String trackingId, {Map<String, dynamic> props})
- : super(trackingId, new MockProperties(props), new MockPostHandler(),
- applicationName: 'Test App', applicationVersion: '0.1');
+ AnalyticsImplMock(String trackingId, {bool setOptIn: true}) :
+ super(trackingId, new MockProperties(), new MockPostHandler(),
+ applicationName: 'Test App', applicationVersion: '0.1') {
+ if (setOptIn) optIn = true;
+ }
Map<String, dynamic> get last => mockPostHandler.last;
}
@@ -30,26 +32,18 @@ class AnalyticsImplMock extends AnalyticsImpl {
class MockProperties extends PersistentProperties {
Map<String, dynamic> props = {};
- MockProperties([Map<String, dynamic> props]) : super('mock') {
- if (props != null) this.props.addAll(props);
- }
+ MockProperties() : super('mock');
- @override
- dynamic operator [](String key) => props[key];
+ dynamic operator[](String key) => props[key];
- @override
- void operator []=(String key, dynamic value) {
+ void operator[]=(String key, dynamic value) {
props[key] = value;
}
-
- @override
- void syncSettings() {}
}
class MockPostHandler extends PostHandler {
List<Map<String, dynamic>> sentValues = [];
- @override
Future sendPost(String url, Map<String, dynamic> parameters) {
sentValues.add(parameters);
@@ -57,7 +51,4 @@ class MockPostHandler extends PostHandler {
}
Map<String, dynamic> get last => sentValues.last;
-
- @override
- void close() {}
}
« no previous file with comments | « packages/usage/test/hit_types_test.dart ('k') | packages/usage/test/usage_impl_io_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698