packages/analyzer/test/src/task/html_test.dart - Issue 2990843002: Removed fixed dependencies

Unified Diff: packages/analyzer/test/src/task/html_test.dart

Issue 2990843002: Removed fixed dependencies (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « packages/analyzer/test/src/task/general_test.dart ('k') | packages/analyzer/test/src/task/html_work_manager_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: packages/analyzer/test/src/task/html_test.dart

diff --git a/packages/analyzer/test/src/task/html_test.dart b/packages/analyzer/test/src/task/html_test.dart

index a90116545e4d7b8d409c0abcf83f9df75409a22c..78fee27fe21c928c56a7ee0ec2366d5fbfbd962a 100644

--- a/packages/analyzer/test/src/task/html_test.dart

+++ b/packages/analyzer/test/src/task/html_test.dart

@@ -2,7 +2,7 @@

// BSD-style license that can be found in the LICENSE file.

-library test.src.task.html_test;

+library analyzer.test.src.task.html_test;

import 'package:analyzer/src/generated/source.dart';

import 'package:analyzer/src/task/html.dart';

@@ -10,17 +10,17 @@ import 'package:analyzer/task/general.dart';

import 'package:analyzer/task/html.dart';

import 'package:analyzer/task/model.dart';

import 'package:html/dom.dart';

+import 'package:test_reflective_loader/test_reflective_loader.dart';

import 'package:unittest/unittest.dart';

-import '../../reflective_tests.dart';

import '../../utils.dart';

import '../context/abstract_context.dart';

main() {

initializeTestEnvironment();

- runReflectiveTests(DartScriptsTaskTest);

- runReflectiveTests(HtmlErrorsTaskTest);

- runReflectiveTests(ParseHtmlTaskTest);

+ defineReflectiveTests(DartScriptsTaskTest);

+ defineReflectiveTests(HtmlErrorsTaskTest);

+ defineReflectiveTests(ParseHtmlTaskTest);

}

isInstanceOf isDartScriptsTask = new isInstanceOf<DartScriptsTask>();

@@ -177,6 +177,23 @@ class DartScriptsTaskTest extends AbstractContextTest {

@reflectiveTest

class HtmlErrorsTaskTest extends AbstractContextTest {

+ fail_perform_htmlErrors() {

+ AnalysisTarget target = newSource(

+ '/test.html',

+ r'''

+<html>

+ <head>

+ <title>test page</not-title>

+ </head>

+ <body>

+ Test

+ </body>

+</html>

+''');

+ computeResult(target, HTML_ERRORS, matcher: isHtmlErrorsTask);

+ expect(outputs[HTML_ERRORS], hasLength(1));

+ }

test_constructor() {

Source source = newSource('/test.html');

HtmlErrorsTask task = new HtmlErrorsTask(context, source);

@@ -223,23 +240,6 @@ class HtmlErrorsTaskTest extends AbstractContextTest {

expect(outputs[HTML_ERRORS], hasLength(1));

}

- test_perform_htmlErrors() {

- AnalysisTarget target = newSource(

- '/test.html',

- r'''

-<html>

- <head>

- <title>test page</not-title>

- </head>

- <body>

- Test

- </body>

-</html>

-''');

- computeResult(target, HTML_ERRORS, matcher: isHtmlErrorsTask);

- expect(outputs[HTML_ERRORS], hasLength(1));

- }

test_perform_noErrors() {

AnalysisTarget target = newSource(

'/test.html',

@@ -265,7 +265,12 @@ class ParseHtmlTaskTest extends AbstractContextTest {

Source source = newSource('/test.html');

Map<String, TaskInput> inputs = ParseHtmlTask.buildInputs(source);

expect(inputs, isNotNull);

- expect(inputs.keys, unorderedEquals([ParseHtmlTask.CONTENT_INPUT_NAME]));

+ expect(

+ inputs.keys,

+ unorderedEquals([

+ ParseHtmlTask.CONTENT_INPUT_NAME,

+ ParseHtmlTask.MODIFICATION_TIME_INPUT

+ ]));

}

test_constructor() {

@@ -303,15 +308,22 @@ class ParseHtmlTaskTest extends AbstractContextTest {

</head>

<body>

- <h1 Test>

+ <h1 myAttr='my value'>Test</h1>

</body>

</html>

''';

AnalysisTarget target = newSource('/test.html', code);

computeResult(target, HTML_DOCUMENT);

expect(task, isParseHtmlTask);

- expect(outputs[HTML_DOCUMENT], isNotNull);

- expect(outputs[HTML_DOCUMENT_ERRORS], isNotEmpty);

+ expect(outputs[HTML_DOCUMENT_ERRORS], isEmpty);

+ // HTML_DOCUMENT

+ {

+ Document document = outputs[HTML_DOCUMENT];

+ expect(document, isNotNull);

+ // verify that attributes are not lower-cased

+ Element element = document.body.getElementsByTagName('h1').single;

+ expect(element.attributes['myAttr'], 'my value');

+ }

// LINE_INFO

{

LineInfo lineInfo = outputs[LINE_INFO];

« no previous file with comments | « packages/analyzer/test/src/task/general_test.dart ('k') | packages/analyzer/test/src/task/html_work_manager_test.dart » ('j') | no next file with comments »