Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: packages/analyzer/lib/src/plugin/plugin_configuration.dart

Issue 2990843002: Removed fixed dependencies (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/analyzer/lib/src/plugin/options_plugin.dart ('k') | packages/analyzer/lib/src/services/lint.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/analyzer/lib/src/plugin/plugin_configuration.dart
diff --git a/packages/analyzer/lib/src/plugin/plugin_configuration.dart b/packages/analyzer/lib/src/plugin/plugin_configuration.dart
index 9365a3c3eefe8a75fa4c31c718874ec12896077f..2137f1195c89aa807315177509eb08b9b770252c 100644
--- a/packages/analyzer/lib/src/plugin/plugin_configuration.dart
+++ b/packages/analyzer/lib/src/plugin/plugin_configuration.dart
@@ -84,10 +84,11 @@ class PluginConfig {
PluginConfig(this.plugins);
/// Create a plugin configuration from an options map.
- factory PluginConfig.fromOptions(Map<String, YamlNode> options) {
+ factory PluginConfig.fromOptions(Map<String, Object> options) {
List<PluginInfo> plugins = [];
var analyzerOptions = options[_analyzerOptionScope];
if (analyzerOptions != null) {
+ //TODO(pq): handle "raw" maps (https://github.com/dart-lang/sdk/issues/25126)
if (analyzerOptions is YamlMap) {
var pluginConfig = analyzerOptions[_pluginOptionScope];
if (pluginConfig is YamlMap) {
@@ -142,8 +143,7 @@ class PluginConfigOptionsProcessor extends OptionsProcessor {
}
@override
- void optionsProcessed(
- AnalysisContext context, Map<String, YamlNode> options) {
+ void optionsProcessed(AnalysisContext context, Map<String, Object> options) {
_config = new PluginConfig.fromOptions(options);
}
}
« no previous file with comments | « packages/analyzer/lib/src/plugin/options_plugin.dart ('k') | packages/analyzer/lib/src/services/lint.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698