Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: packages/plugin/test/plugin_impl_test.dart

Issue 2990843002: Removed fixed dependencies (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packages/plugin/pubspec.yaml ('k') | packages/typed_data/.gitignore » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packages/plugin/test/plugin_impl_test.dart
diff --git a/packages/plugin/test/plugin_impl_test.dart b/packages/plugin/test/plugin_impl_test.dart
index 5d2902f302e5fa7026cf72362693a9d40c5f5f29..2221cf81ced78346808871cdc4260913d80df848 100644
--- a/packages/plugin/test/plugin_impl_test.dart
+++ b/packages/plugin/test/plugin_impl_test.dart
@@ -6,11 +6,9 @@ library test.operation;
import 'package:plugin/plugin.dart';
import 'package:plugin/src/plugin_impl.dart';
-import 'package:unittest/unittest.dart';
+import 'package:test/test.dart';
main() {
- groupSep = ' | ';
-
group('ExtensionManager', () {
test('processPlugins', () {
TestPlugin plugin1 = new TestPlugin('plugin1');
@@ -26,8 +24,8 @@ main() {
test('registerExtension - valid', () {
Plugin plugin = new TestPlugin('plugin');
ExtensionManagerImpl manager = new ExtensionManagerImpl();
- ExtensionPoint point =
- manager.registerExtensionPoint(plugin, 'point', null);
+ ExtensionPoint point = new ExtensionPoint(plugin, 'point', null);
+ manager.registerExtensionPoint(point);
expect(point, isNotNull);
Object extension = 'extension';
manager.registerExtension('plugin.point', extension);
@@ -48,22 +46,24 @@ main() {
Plugin plugin1 = new TestPlugin('plugin1');
Plugin plugin2 = new TestPlugin('plugin2');
ExtensionManagerImpl manager = new ExtensionManagerImpl();
- expect(
- manager.registerExtensionPoint(plugin1, 'point1', null), isNotNull);
- expect(
- manager.registerExtensionPoint(plugin1, 'point2', null), isNotNull);
- expect(
- manager.registerExtensionPoint(plugin2, 'point1', null), isNotNull);
- expect(
- manager.registerExtensionPoint(plugin2, 'point2', null), isNotNull);
+ manager
+ .registerExtensionPoint(new ExtensionPoint(plugin1, 'point1', null));
+ manager
+ .registerExtensionPoint(new ExtensionPoint(plugin1, 'point2', null));
+ manager
+ .registerExtensionPoint(new ExtensionPoint(plugin2, 'point1', null));
+ manager
+ .registerExtensionPoint(new ExtensionPoint(plugin2, 'point2', null));
});
test('registerExtensionPoint - conflicting - same plugin', () {
Plugin plugin1 = new TestPlugin('plugin1');
ExtensionManagerImpl manager = new ExtensionManagerImpl();
+ manager
+ .registerExtensionPoint(new ExtensionPoint(plugin1, 'point1', null));
expect(
- manager.registerExtensionPoint(plugin1, 'point1', null), isNotNull);
- expect(() => manager.registerExtensionPoint(plugin1, 'point1', null),
+ () => manager.registerExtensionPoint(
+ new ExtensionPoint(plugin1, 'point1', null)),
throwsA(new isInstanceOf<ExtensionError>()));
});
@@ -71,9 +71,11 @@ main() {
Plugin plugin1 = new TestPlugin('plugin1');
Plugin plugin2 = new TestPlugin('plugin1');
ExtensionManagerImpl manager = new ExtensionManagerImpl();
+ manager
+ .registerExtensionPoint(new ExtensionPoint(plugin1, 'point1', null));
expect(
- manager.registerExtensionPoint(plugin1, 'point1', null), isNotNull);
- expect(() => manager.registerExtensionPoint(plugin2, 'point1', null),
+ () => manager.registerExtensionPoint(
+ new ExtensionPoint(plugin2, 'point1', null)),
throwsA(new isInstanceOf<ExtensionError>()));
});
});
@@ -117,8 +119,8 @@ main() {
test('add - with validator - valid', () {
Plugin plugin = new TestPlugin('plugin');
- ExtensionPointImpl point = new ExtensionPointImpl(plugin, 'point',
- (Object extension) {
+ ExtensionPointImpl point =
+ new ExtensionPointImpl(plugin, 'point', (Object extension) {
if (extension is! String) {
throw new ExtensionError('');
}
@@ -128,8 +130,8 @@ main() {
test('add - with validator - invalid', () {
Plugin plugin = new TestPlugin('plugin');
- ExtensionPointImpl point = new ExtensionPointImpl(plugin, 'point',
- (Object extension) {
+ ExtensionPointImpl point =
+ new ExtensionPointImpl(plugin, 'point', (Object extension) {
if (extension is! String) {
throw new ExtensionError('');
}
« no previous file with comments | « packages/plugin/pubspec.yaml ('k') | packages/typed_data/.gitignore » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698