Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2990833002: Fix for issue 29819 (Closed)

Created:
3 years, 4 months ago by siva
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 29819 https://github.com/dart-lang/sdk/issues/29819 when a 'dill' file is loaded directly into the VM, set mode to dart front end mode and use that when reloading files too, this ensures that we reload correctly. Adjust pkg.status to account for the hot_reload_e2e_test passing. R=aam@google.com https://github.com/dart-lang/sdk/issues/29819 Committed: https://github.com/dart-lang/sdk/commit/53cf85abc80fc804caddc2c680e696d6e6049113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/dfe.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/bin/dfe.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
siva
3 years, 4 months ago (2017-07-27 02:22:03 UTC) #3
aam
woah! lgtm!
3 years, 4 months ago (2017-07-27 03:15:50 UTC) #4
siva
3 years, 4 months ago (2017-07-27 17:06:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53cf85abc80fc804caddc2c680e696d6e6049113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698