Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: runtime/lib/mirrors.cc

Issue 2990823002: [vm, mirrors] Remove Dartium's dart:io hack. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 04a4797f4e3351b8de68bf1dbf5bcdc85e2d564b..8e2b560d8b7053e452658f5265135392546c20ae 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -357,21 +357,6 @@ static RawInstance* CreateLibraryMirror(Thread* thread, const Library& lib) {
return Instance::null();
}
}
- if (str.Equals("dart:io")) {
- // Hack around dart:io being loaded into non-service isolates in Dartium.
- Isolate* isolate = thread->isolate();
- const GrowableObjectArray& libraries =
- GrowableObjectArray::Handle(zone, isolate->object_store()->libraries());
- Library& other_lib = Library::Handle(zone);
- String& other_uri = String::Handle(zone);
- for (intptr_t i = 0; i < libraries.Length(); i++) {
- other_lib ^= libraries.At(i);
- other_uri = other_lib.url();
- if (other_uri.Equals("dart:html")) {
- return Instance::null();
- }
- }
- }
args.SetAt(2, str);
return CreateMirror(Symbols::_LocalLibraryMirror(), args);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698