Issue 2990793002: Improve name generation for indexed expressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2990793002: Improve name generation for indexed expressions (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson

Modified:
3 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -69 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/name_suggestion.dart	View	3 chunks	+41 lines, -34 lines	0 comments	Download
M	pkg/analysis_server/test/abstract_context.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart	View	3 chunks	+40 lines, -33 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

There's an unrelated change to test support that slipped in. I'll back it out if ...

3 years, 4 months ago (2017-07-26 21:52:58 UTC) #2

Brian Wilkerson

3 years, 4 months ago (2017-07-27 14:58:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9a6b134d330e4ef38b98b6199e895d0dbc9236a8 (presubmit successful).