Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart

Issue 2990733002: Don't resynthesize invalid constant expressions at all. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_common.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart b/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
index e20735f6eded188c3d104b7dd407ae5e718bd1d5..6bc22d708038ae040ec97db6ced74d7f4c5a65da 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
@@ -159,16 +159,13 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
+ @fastaProblem
test_const_invalid_field_const() async {
+ // Fasta generates additional `#errors` top-level variable.
await super.test_const_invalid_field_const();
}
@failingTest
- test_const_invalid_field_final() async {
- await super.test_const_invalid_field_final();
- }
-
- @failingTest
@fastaProblem
test_const_invalid_intLiteral() async {
// https://github.com/dart-lang/sdk/issues/30266
@@ -176,7 +173,9 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
+ @fastaProblem
test_const_invalid_topLevel() async {
+ // Fasta generates additional `#errors` top-level variable.
await super.test_const_invalid_topLevel();
}
@@ -560,11 +559,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_expr_invalid_typeParameter_asPrefix() async {
- await super.test_expr_invalid_typeParameter_asPrefix();
- }
-
- @failingTest
test_field_covariant() async {
await super.test_field_covariant();
}
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_common.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698