Issue 2990733002: Don't resynthesize invalid constant expressions at all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2990733002: Don't resynthesize invalid constant expressions at all. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -37 lines)			Patch
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/element_text.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_common.dart	View	8 chunks	+10 lines, -24 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart	View	3 chunks	+4 lines, -10 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-07-26 18:13:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89c58dd1169cd4d2c31f03e7c8cc71dacb665d10 (presubmit successful).