Issue 2990723002: Revert "Implemented support for generalized void in analyzer."

Issue 2990723002: Revert "Implemented support for generalized void in analyzer." (Closed)

Created:
3 years, 4 months ago by eernst

Modified:
3 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, floitsch

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Implemented support for generalized void in analyzer." This reverts commit 1d44f5296a711c5f60c99a525db1458014c3fe41, because it causes failures for the analyzer in parser_test, error_test. Committed: https://github.com/dart-lang/sdk/commit/2e73ce11875585bd220d96d829d763e8424a4e19

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -138 lines)			Patch
M	pkg/analyzer/lib/error/error.dart	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/error/syntactic_errors.dart	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/error/codes.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	29 chunks	+94 lines, -81 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	5 chunks	+15 lines, -21 lines	0 comments	Download
M	pkg/analyzer/test/generated/static_warning_code_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-analyzer2.status	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	tests/language/generalized_void_syntax_test.dart	View	3 chunks	+14 lines, -17 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/language/syntax_test.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 5 (2 generated)

eernst

TBR, needs revert because of failures in pkg/analyzer/test/generated/parser_test and pkg/analyzer_cli/test/error_test.

3 years, 4 months ago (2017-07-26 16:17:50 UTC) #2

eernst

Committed patchset #1 (id:1) manually as 2e73ce11875585bd220d96d829d763e8424a4e19 (presubmit successful).

3 years, 4 months ago (2017-07-26 16:18:09 UTC) #4

Message was sent while issue was closed.

lgtm