Chromium Code Reviews Chromium Code Reviews
Issue 2990713002:
config_service: change error message for error 403. (Closed)
| OLD | NEW |
|---|---|
| 1 <!-- | 1 <!-- |
| 2 Copyright 2017 The LUCI Authors. All rights reserved. | 2 Copyright 2017 The LUCI Authors. All rights reserved. |
| 3 Use of this source code is governed under the Apache License, Version 2.0 | 3 Use of this source code is governed under the Apache License, Version 2.0 |
| 4 that can be found in the LICENSE file. | 4 that can be found in the LICENSE file. |
| 5 --> | 5 --> |
| 6 | 6 |
| 7 <!doctype html> | 7 <!doctype html> |
| 8 <html lang="en"> | 8 <html lang="en"> |
| 9 <head> | 9 <head> |
| 10 <meta charset="utf-8"> | 10 <meta charset="utf-8"> |
| (...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 286 403, | 286 403, |
| 287 responseHeaders.json, | 287 responseHeaders.json, |
| 288 JSON.stringify(param) | 288 JSON.stringify(param) |
| 289 ] | 289 ] |
| 290 ); | 290 ); |
| 291 request = ajax.generateRequest(); | 291 request = ajax.generateRequest(); |
| 292 server.respond(); | 292 server.respond(); |
| 293 assert.equal(request.status, 403); | 293 assert.equal(request.status, 403); |
| 294 config_set.addEventListener('fetchError', function() { | 294 config_set.addEventListener('fetchError', function() { |
| 295 assert.equal(config_set.isLoading, false); | 295 assert.equal(config_set.isLoading, false); |
| 296 assert.equal(config_set.errorMessage, "Authorization required to vie w this config set." + | 296 assert.equal(config_set.errorMessage, "Access denied. If you are not signed in, please do so. " + |
| 297 " Please sign in."); | 297 "Otherwise, try again later."); |
|
Sergey Berezin
2017/07/26 22:35:50
Shouldn't the tests be updated with the new messag
ayanaadylova
2017/07/26 22:49:07
Done.
| |
| 298 done(); | 298 done(); |
| 299 }.bind(config_set)); | 299 }.bind(config_set)); |
| 300 }); | 300 }); |
| 301 | 301 |
| 302 test('displays error if fetch failed due to error 500', function (done) { | 302 test('displays error if fetch failed due to error 500', function (done) { |
| 303 param = { | 303 param = { |
| 304 error: { | 304 error: { |
| 305 code: 500, | 305 code: 500, |
| 306 message: "Error 500" | 306 message: "Error 500" |
| 307 } | 307 } |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 323 assert.equal(config_set.errorMessage, "Internal server error."); | 323 assert.equal(config_set.errorMessage, "Internal server error."); |
| 324 done(); | 324 done(); |
| 325 }.bind(config_set)); | 325 }.bind(config_set)); |
| 326 }); | 326 }); |
| 327 | 327 |
| 328 }); | 328 }); |
| 329 | 329 |
| 330 </script> | 330 </script> |
| 331 </body> | 331 </body> |
| 332 </html> | 332 </html> |
| OLD | NEW |
