Add patched_dart2js_sdk to the dart2js_bot build target

Add patched_dart2js_sdk to the dart2js_bot build target

This should ensure this is available in the build bots.

R=sra@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/08890e6db7274f17efa3d1773fcea0e01e38421c

[Siggi Cherem (dart-lang), 2017-07-25 19:26:53]

sigmund@google.com changed reviewers:
+ sra@chromium.org

[zra, 2017-07-25 19:30:53]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2017-07-25 19:30:54]

https://codereview.chromium.org/2990633002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2990633002/diff/1/BUILD.gn#newcode114
BUILD.gn:114: "utils/compiler:dart2js",
This target should already be built by the :create_sdk target. Is that not
happening?

[sra1, 2017-07-25 19:31:21]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-07-25 19:31:21]

lgtm

[zra, 2017-07-25 19:32:10]

not lgtm

[Siggi Cherem (dart-lang), 2017-07-25 19:33:00]

https://codereview.chromium.org/2990633002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2990633002/diff/1/BUILD.gn#newcode114
BUILD.gn:114: "utils/compiler:dart2js",
On 2017/07/25 19:30:54, zra wrote:
> This target should already be built by the :create_sdk target. Is that not
> happening?

Sorry, this was stupid mistake that I noticed as I turned around to talk with
Stephen and I just fixed in my new patch.

I meant to write patched_dart2js_sdk (which is not a dependency of :dart2js)

[Siggi Cherem (dart-lang), 2017-07-25 19:33:23]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-25 19:34:20]

On 2017/07/25 19:33:00, Siggi Cherem (dart-lang) wrote:
> https://codereview.chromium.org/2990633002/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2990633002/diff/1/BUILD.gn#newcode114
> BUILD.gn:114: "utils/compiler:dart2js",
> On 2017/07/25 19:30:54, zra wrote:
> > This target should already be built by the :create_sdk target. Is that not
> > happening?
> 
> Sorry, this was stupid mistake that I noticed as I turned around to talk with
> Stephen and I just fixed in my new patch.
> 
> I meant to write patched_dart2js_sdk (which is not a dependency of :dart2js)

OK, new patchset has the fix, PTAL

Good (and quick) catch!

[zra, 2017-07-25 19:35:28]

Ah okay, thanks for the explanation =) lgtm

[Siggi Cherem (dart-lang), 2017-07-25 19:36:01]

(note - Stephen gave me the green light earlier because he knew I was about to
fix it)

[Siggi Cherem (dart-lang), 2017-07-25 19:36:51]

Description was changed from

==========
Add patched_dart2js_sdk to the dart2js_bot build target

This should ensure this is available in the build bots.
==========

to

==========
Add patched_dart2js_sdk to the dart2js_bot build target

This should ensure this is available in the build bots.

R=sra@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/08890e6db7274f17efa3d1773fcea0e01e38421c
==========

[Siggi Cherem (dart-lang), 2017-07-25 19:36:52]

Committed patchset #2 (id:40001) manually as
08890e6db7274f17efa3d1773fcea0e01e38421c (presubmit successful).