Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: tests/corelib_2/hash_set_type_check_test.dart

Issue 2990623002: Migrate test block 9 to Dart 2.0 (Closed)
Patch Set: nits Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/corelib_2/hash_set_test.dart ('k') | tests/corelib_2/hashcode_boxed_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib_2/hash_set_type_check_test.dart
diff --git a/tests/corelib/hash_set_type_check_test.dart b/tests/corelib_2/hash_set_type_check_test.dart
similarity index 54%
rename from tests/corelib/hash_set_type_check_test.dart
rename to tests/corelib_2/hash_set_type_check_test.dart
index 27c7908423e56c73b982c5f9b24b7a00345b66de..e51c88d7bd6a17aab9df7af153939128bb85de56 100644
--- a/tests/corelib/hash_set_type_check_test.dart
+++ b/tests/corelib_2/hash_set_type_check_test.dart
@@ -9,39 +9,22 @@ library hash_set_type_check_test;
import "package:expect/expect.dart";
import 'dart:collection';
+// TODO: all this test does now is verify that lookup takes a non-T
+// should merge this with `hash_test_test`.
testSet(Set<String> newSet()) {
Set<String> s = newSet();
- Expect.throws(() => s.add(1), (e) => e is Error);
Expect.isNull(s.lookup(1));
}
-void testIdentitySet(Set create()) {
- Set<String> s = create();
- Expect.throws(() => s.add(1), (e) => e is Error);
- Expect.isNull(s.lookup(1));
-}
-
-bool get inCheckedMode {
- try {
- var i = 1;
- String j = i;
- } catch (_) {
- return true;
- }
- return false;
-}
-
void main() {
- if (!inCheckedMode) return;
-
testSet(() => new Set<String>());
testSet(() => new HashSet<String>());
testSet(() => new LinkedHashSet<String>());
- testIdentitySet(() => new Set<String>.identity());
- testIdentitySet(() => new HashSet<String>.identity());
- testIdentitySet(() => new LinkedHashSet<String>.identity());
- testIdentitySet(() => new HashSet<String>(
+ testSet(() => new Set<String>.identity());
+ testSet(() => new HashSet<String>.identity());
+ testSet(() => new LinkedHashSet<String>.identity());
+ testSet(() => new HashSet<String>(
equals: (x, y) => identical(x, y), hashCode: (x) => identityHashCode(x)));
- testIdentitySet(() => new LinkedHashSet<String>(
+ testSet(() => new LinkedHashSet<String>(
equals: (x, y) => identical(x, y), hashCode: (x) => identityHashCode(x)));
}
« no previous file with comments | « tests/corelib_2/hash_set_test.dart ('k') | tests/corelib_2/hashcode_boxed_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698