Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990603003: Migrated test block 23 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 23 to Dart 2.0. No major changes. Updated regexp_test.dart to not use the same variable for Strings and Regexps. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/4479a894678ce034deb4010f8e285a05f01bbdeb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed issues caused by s/re/regexp/g #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2017 lines) Patch
M tests/corelib/corelib.status View 2 chunks +0 lines, -15 lines 0 comments Download
D tests/corelib/regexp/quantified-assertions_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/corelib/regexp/range-bound-ffff_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib/regexp/range-out-of-order_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib/regexp/ranges-and-escaped-hyphens_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib/regexp/regexp_kde_test.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/corelib/regexp/regexp_test.dart View 1 chunk +0 lines, -622 lines 0 comments Download
D tests/corelib/regexp/regress-6-9-regexp_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 3 chunks +14 lines, -0 lines 0 comments Download
A + tests/corelib_2/regexp/quantified-assertions_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/range-bound-ffff_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/range-out-of-order_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/ranges-and-escaped-hyphens_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/regexp_kde_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regexp/regexp_test.dart View 1 18 chunks +87 lines, -84 lines 1 comment Download
A + tests/corelib_2/regexp/regress-6-9-regexp_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -6 lines 0 comments Download
D tests/corelib_strong/regexp/quantified-assertions_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D tests/corelib_strong/regexp/range-bound-ffff_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib_strong/regexp/range-out-of-order_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib_strong/regexp/ranges-and-escaped-hyphens_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download
D tests/corelib_strong/regexp/regexp_kde_test.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/corelib_strong/regexp/regexp_test.dart View 1 chunk +0 lines, -598 lines 0 comments Download
D tests/corelib_strong/regexp/regress-6-9-regexp_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bkonyi
3 years, 4 months ago (2017-07-26 16:42:13 UTC) #2
Bob Nystrom
https://codereview.chromium.org/2990603003/diff/1/tests/corelib_2/regexp/regexp_test.dart File tests/corelib_2/regexp/regexp_test.dart (right): https://codereview.chromium.org/2990603003/diff/1/tests/corelib_2/regexp/regexp_test.dart#newcode1 tests/corelib_2/regexp/regexp_test.dart:1: // Copyright (c) 2014, the Dart project authors. All ...
3 years, 4 months ago (2017-07-26 20:14:45 UTC) #3
bkonyi
https://codereview.chromium.org/2990603003/diff/1/tests/corelib_2/regexp/regexp_test.dart File tests/corelib_2/regexp/regexp_test.dart (right): https://codereview.chromium.org/2990603003/diff/1/tests/corelib_2/regexp/regexp_test.dart#newcode1 tests/corelib_2/regexp/regexp_test.dart:1: // Copyright (c) 2014, the Dart project authors. All ...
3 years, 4 months ago (2017-07-26 20:30:34 UTC) #4
Bob Nystrom
Fix the other replace mistakes then LGTM. :) https://codereview.chromium.org/2990603003/diff/20001/tests/corelib_2/regexp/regexp_test.dart File tests/corelib_2/regexp/regexp_test.dart (right): https://codereview.chromium.org/2990603003/diff/20001/tests/corelib_2/regexp/regexp_test.dart#newcode47 tests/corelib_2/regexp/regexp_test.dart:47: // ...
3 years, 4 months ago (2017-07-26 23:54:49 UTC) #5
bkonyi
3 years, 4 months ago (2017-07-27 19:10:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4479a894678ce034deb4010f8e285a05f01bbdeb.

Powered by Google App Engine
This is Rietveld 408576698