Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990603002: Extract KernelResynthesizer from tests into analyzer/lib. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -528 lines) Patch
A pkg/analyzer/lib/src/kernel/resynthesize.dart View 1 chunk +546 lines, -0 lines 4 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 4 chunks +2 lines, -528 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scheglov
3 years, 5 months ago (2017-07-25 16:43:01 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart File pkg/analyzer/lib/src/kernel/resynthesize.dart (right): https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart#newcode4 pkg/analyzer/lib/src/kernel/resynthesize.dart:4: library analyzer.kernel.resynthesize; personal preference: remove library directives
3 years, 5 months ago (2017-07-25 16:47:40 UTC) #2
scheglov
https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart File pkg/analyzer/lib/src/kernel/resynthesize.dart (right): https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart#newcode4 pkg/analyzer/lib/src/kernel/resynthesize.dart:4: library analyzer.kernel.resynthesize; On 2017/07/25 16:47:40, Brian Wilkerson wrote: > ...
3 years, 5 months ago (2017-07-25 16:55:04 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 7bdfd098f6d53c0f68c7a5d7564e1934befea563 (presubmit successful).
3 years, 5 months ago (2017-07-25 16:56:20 UTC) #5
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart File pkg/analyzer/lib/src/kernel/resynthesize.dart (right): https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart#newcode4 pkg/analyzer/lib/src/kernel/resynthesize.dart:4: library analyzer.kernel.resynthesize; On 2017/07/25 16:47:40, Brian Wilkerson wrote: ...
3 years, 5 months ago (2017-07-25 16:56:50 UTC) #6
Brian Wilkerson
3 years, 5 months ago (2017-07-25 17:09:37 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel...
File pkg/analyzer/lib/src/kernel/resynthesize.dart (right):

https://codereview.chromium.org/2990603002/diff/1/pkg/analyzer/lib/src/kernel...
pkg/analyzer/lib/src/kernel/resynthesize.dart:4: library
analyzer.kernel.resynthesize;
> I like having them when adding library-level documentation on them

I'm fine having library docs on the first directive (dartdoc deals with it being
associated with any directive and I've never wanted to put any other kind of
dartdoc on a directive), but you do have to have a library if there are no other
directives to put the doc on (otherwise it associates with the first
declaration).

Powered by Google App Engine
This is Rietveld 408576698