Parse documentation for class aliases, fix for /// comments.

Parse documentation for class aliases, fix for /// comments.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/2d01f1f8d9c992fb3da442b6550213d2555f2f3c

[scheglov, 2017-07-24 16:12:41]

Description was changed from

==========
Parse documentation for class aliases, fix for /// comments.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Parse documentation for class aliases, fix for /// comments.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

[scheglov, 2017-07-24 16:12:42]

scheglov@google.com changed reviewers:
+ brianwilkerson@google.com
- paulberry@google.com

[Siggi Cherem (dart-lang), 2017-07-24 17:34:47]

https://codereview.chromium.org/2990523002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/outline_builder.dart (right):

https://codereview.chromium.org/2990523002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/outline_builder.dart:922: if
(lexeme.startsWith('///') || lexeme.startsWith('/**')) {
I understand that the reason for this loop is to ensure comments like:
 /// line A1
 /// line A2

include both A1 and A2 (not just A1).

But it seems we are also concatenating to dartdocs like /** */ for example:
 /** line B1 */
 /** line B2 */

Is this the intent? Or is the dartdoc only supposed to be line B2 in this case?

If so, let's update the logic here accordingly.

Either way, let's add a test to ensure we are tracking the behavior we want.

[scheglov, 2017-07-24 19:13:38]

PTAL

https://codereview.chromium.org/2990523002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/outline_builder.dart (right):

https://codereview.chromium.org/2990523002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/outline_builder.dart:922: if
(lexeme.startsWith('///') || lexeme.startsWith('/**')) {
On 2017/07/24 17:34:47, Siggi Cherem (dart-lang) wrote:
> I understand that the reason for this loop is to ensure comments like:
>  /// line A1
>  /// line A2
> 
> include both A1 and A2 (not just A1).
> 
> But it seems we are also concatenating to dartdocs like /** */ for example:
>  /** line B1 */
>  /** line B2 */
> 
> Is this the intent? Or is the dartdoc only supposed to be line B2 in this
case?
> 
> If so, let's update the logic here accordingly.
> 
> Either way, let's add a test to ensure we are tracking the behavior we want.

Done.

[Siggi Cherem (dart-lang), 2017-07-24 23:58:04]

lgtm

[scheglov, 2017-07-25 05:15:26]

Description was changed from

==========
Parse documentation for class aliases, fix for /// comments.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Parse documentation for class aliases, fix for /// comments.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/2d01f1f8d9c992fb3da442b6550213d2555f2f3c
==========

[scheglov, 2017-07-25 05:15:27]

Committed patchset #2 (id:20001) manually as
2d01f1f8d9c992fb3da442b6550213d2555f2f3c (presubmit successful).