Adding bindless variants mailbox produce/consume

gpu/GLES2/gl2extchromium.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains Chromium-specific GLES2 extensions declarations.
 
 #ifndef GPU_GLES2_GL2EXTCHROMIUM_H_
 #define GPU_GLES2_GL2EXTCHROMIUM_H_
 
 #include <GLES2/gl2.h>
@@ skipping 37 matching lines @@
 #ifndef GL_CHROMIUM_texture_mailbox
 #define GL_CHROMIUM_texture_mailbox 1
 
 #ifndef GL_MAILBOX_SIZE_CHROMIUM
 #define GL_MAILBOX_SIZE_CHROMIUM 64
 #endif
 #ifdef GL_GLEXT_PROTOTYPES
 GL_APICALL void GL_APIENTRY glGenMailboxCHROMIUM(GLbyte* mailbox);
 GL_APICALL void GL_APIENTRY glProduceTextureCHROMIUM(
     GLenum target, const GLbyte* mailbox);
+GL_APICALL void GL_APIENTRY glProduceTextureBindlessCHROMIUM(

[Ken Russell (switch to Gerrit), 2014/05/23 04:04:41]

I think the term "bindless" might cause confusion with the OpenGL concepts of
bindless textures. Could we choose another name? ProduceFromTextureCHROMIUM?
Something else? I think ideally the old entry point would be removed once all
call sites are switched to the new one. Perhaps it could just be temporarily
called glProduceTextureNewCHROMIUM or glProduceTexture2CHROMIUM. Then everyone
could be switched over to the new one; the old one could be replaced with the
new signature; everyone switched back; and the new temporary one deleted.

+    GLuint texture, GLenum target, const GLbyte* mailbox);

[piman, 2014/05/22 21:53:58]

Nit: the GL-y way is to have target before texture.

 GL_APICALL void GL_APIENTRY glConsumeTextureCHROMIUM(
     GLenum target, const GLbyte* mailbox);
+GL_APICALL GLuint GL_APIENTRY glCreateAndConsumeTextureCHROMIUM(
+    GLenum target, const GLbyte* mailbox);
 #endif
 typedef void (GL_APIENTRYP PFNGLGENMAILBOXCHROMIUMPROC) (GLbyte* mailbox);
 typedef void (GL_APIENTRYP PFNGLPRODUCETEXTURECHROMIUMPROC) (
     GLenum target, const GLbyte* mailbox);
+typedef void (GL_APIENTRYP PFNGLPRODUCETEXTUREBINDLESSCHROMIUMPROC) (
+    GLenum target, const GLbyte* mailbox);

[Ken Russell (switch to Gerrit), 2014/05/23 04:04:41]

The signature of the function pointer doesn't match the prototype above.

 typedef void (GL_APIENTRYP PFNGLCONSUMETEXTURECHROMIUMPROC) (
     GLenum target, const GLbyte* mailbox);
+typedef GLuint (GL_APIENTRYP PFNGLCREATEANDCONSUMETEXTURECHROMIUMPROC) (
+    GLenum target, const GLbyte* mailbox);
 #endif  /* GL_CHROMIUM_texture_mailbox */
 
 /* GL_CHROMIUM_pixel_transfer_buffer_object */
 #ifndef GL_CHROMIUM_pixel_transfer_buffer_object
 #define GL_CHROMIUM_pixel_transfer_buffer_object 1
 
 #ifndef GL_PIXEL_UNPACK_TRANSFER_BUFFER_CHROMIUM
 // TODO(reveman): Get official numbers for this constants.
 #define GL_PIXEL_UNPACK_TRANSFER_BUFFER_CHROMIUM 0x78EC
 #define GL_PIXEL_PACK_TRANSFER_BUFFER_CHROMIUM 0x78ED
@@ skipping 631 matching lines @@
 #ifndef GL_COMMANDS_COMPLETED_CHROMIUM
 #define GL_COMMANDS_COMPLETED_CHROMIUM 0x84F7
 #endif
 #endif  /* GL_CHROMIUM_sync_query */
 
 #ifdef __cplusplus
 }
 #endif
 
 #endif  // GPU_GLES2_GL2EXTCHROMIUM_H_