[vm] Make the crash reporter more resilient to crashes during safepoints.

[vm] Make the crash reporter more resilient to crashes during safepoints.

R=asiva@google.com, danunez@google.com

Committed: https://github.com/dart-lang/sdk/commit/919fdaeb6714b436494f93d524ab6ad98f24850e

[rmacnak, 2017-08-08 20:28:03]

rmacnak@google.com changed reviewers:
+ asiva@google.com, danunez@google.com

[danunez, 2017-08-08 20:44:02]

lgtm w/ comments

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc#newc...
runtime/vm/profiler.cc:414: // current isolate's heap.
This comment is unclear to me. It reads like there is a word missing.

[siva, 2017-08-08 23:59:55]

lgtm

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc#newc...
runtime/vm/profiler.cc:424: }
why not 

Code& code = Code::Handle(Code::LookupCodeInVmIsolate(pc));
if (code.IsNull()) {
  code = Code::LookupCode(pc);
}
if (!code.IsNull()) {
  OS::PrintErr("  [0x%" Pp "] %s\n", pc, code.QualifiedName());
  return;
}

[rmacnak, 2017-08-09 17:58:40]

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc#newc...
runtime/vm/profiler.cc:414: // current isolate's heap.
On 2017/08/08 20:44:02, danunez wrote:
> This comment is unclear to me. It reads like there is a word missing.

Deleted "have"

https://codereview.chromium.org/2990393002/diff/1/runtime/vm/profiler.cc#newc...
runtime/vm/profiler.cc:424: }
On 2017/08/08 23:59:55, siva wrote:
> why not 
> 
> Code& code = Code::Handle(Code::LookupCodeInVmIsolate(pc));
> if (code.IsNull()) {
>   code = Code::LookupCode(pc);
> }
> if (!code.IsNull()) {
>   OS::PrintErr("  [0x%" Pp "] %s\n", pc, code.QualifiedName());
>   return;
> }

Done.

[rmacnak, 2017-08-09 17:59:05]

Description was changed from

==========
[vm] Make the crash reporter more resilient to crashes during safepoints.
==========

to

==========
[vm] Make the crash reporter more resilient to crashes during safepoints.

R=asiva@google.com, danunez@google.com

Committed:
https://github.com/dart-lang/sdk/commit/919fdaeb6714b436494f93d524ab6ad98f24850e
==========

[rmacnak, 2017-08-09 17:59:06]

Committed patchset #2 (id:20001) manually as
919fdaeb6714b436494f93d524ab6ad98f24850e (presubmit successful).