Issue 299033002: Turn on preprocessing by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299033002: Turn on preprocessing by default (Closed)

Created:
6 years, 7 months ago by robertphillips

Modified:
6 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Turn on preprocessing by default The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs. Committed: http://code.google.com/p/skia/source/detail?r=14860

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/bench_pictures_main.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 7 months ago (2014-05-22 23:21:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/299033002/1

6 years, 7 months ago (2014-05-22 23:22:07 UTC) #4

robertphillips

6 years, 7 months ago (2014-05-23 01:01:52 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/299123002/ by robertphillips@google.com.

The reason for reverting is: Don't want this enabled by default right now.

Expand Messages | Collapse Messages