Issue 29903002: Revert "[PDF] Add unpremultiply support and a GM (try3)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 29903002: Revert "[PDF] Add unpremultiply support and a GM (try3)." (Closed)

Created:
7 years, 2 months ago by vandebo (ex-Chrome)

Modified:
7 years, 2 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert "[PDF] Add unpremultiply support and a GM (try3)." This is crashing in some configurations, can now repro. This reverts commit 12add177d0ab7bbac97f5093c9382924d88bde8c. Committed: https://code.google.com/p/skia/source/detail?r=11868

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -294 lines)			Patch
D	gm/bitmappremul.cpp	View	1 chunk	+0 lines, -131 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View	2 chunks	+2 lines, -162 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

7 years, 2 months ago (2013-10-18 21:04:57 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r11868 (presubmit successful).

Expand Messages | Collapse Messages