tracing/tracing/value/ui/merged_revision_info_span_test.html - Issue 2990293002: Revision Info into GenericSet

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/value/ui/merged_revision_info_span_test.html

Issue 2990293002: Revision Info into GenericSet (Closed)

Patch Set: Address Ben's comments Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <!--

3 Copyright 2017 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.

6 -->

7

8 <link rel="import" href="/tracing/value/diagnostics/merged_revision_info.html">

9 <link rel="import" href="/tracing/value/diagnostics/revision_info.html">

10 <link rel="import" href="/tracing/value/ui/diagnostic_span.html">

11

12 <script>

13 'use strict';

14

15 tr.b.unittest.testSuite(function() {

16 test('instantiate', function() {

17 const aRevs = new tr.v.d.RevisionInfo({

18 chromium: ['b10563e'],

19 v8: ['0a12a6'],

20 catapult: ['e6e086'],

21 angle: ['d7b1ab'],

22 skia: ['966bb3'],

23 webrtc: ['277b25'],

24 });

25 const bRevs = new tr.v.d.RevisionInfo({

26 chromium: ['e2ebe328', 'b10563e'],

27 v8: ['0a12a6', '921d88'],

28 catapult: ['e6e086', 'bf0f62'],

29 angle: ['d7b1ab', 'da9fb0'],

30 skia: ['966bb3', 'db402c'],

31 webrtc: ['277b25', 'f8b262'],

32 });

33 const merged = aRevs.clone();

34 merged.addDiagnostic(bRevs);

35 const span = tr.v.ui.createDiagnosticSpan(merged);

36 assert.strictEqual('TR-V-UI-MERGED-REVISION-INFO-SPAN', span.tagName);

37 this.addHTMLOutput(span);

38 });

39 });

40 </script>

OLD	NEW