Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2990233003: Filter unreachable libraries in kernel loader (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Filter unreachable libraries in kernel loader BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/bcaff5e269504a147c3bd2133ce16cb20a37adc8

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased, updated status #

Patch Set 3 : include core, format update script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -39 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 1 2 1 chunk +27 lines, -4 lines 0 comments Download
M pkg/compiler/tool/status_files/update_all.sh View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 4 chunks +45 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
I'm in the process of updating all the status files, I'll upload a new patchset ...
3 years, 4 months ago (2017-08-03 22:20:25 UTC) #3
sra1
https://codereview.chromium.org/2990233003/diff/20001/pkg/compiler/lib/src/library_loader.dart File pkg/compiler/lib/src/library_loader.dart (right): https://codereview.chromium.org/2990233003/diff/20001/pkg/compiler/lib/src/library_loader.dart#newcode903 pkg/compiler/lib/src/library_loader.dart:903: '_native_typed_data', This will be a problem for the dart2js_native ...
3 years, 4 months ago (2017-08-03 22:26:14 UTC) #4
sra1
lgtm
3 years, 4 months ago (2017-08-03 22:39:38 UTC) #5
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-09 18:01:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as
bcaff5e269504a147c3bd2133ce16cb20a37adc8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698