Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2990183002: Revert of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. (Closed)

Created:
3 years, 4 months ago by philipel
Modified:
3 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. (patchset #5 id:80001 of https://codereview.chromium.org/2993513002/ ) Reason for revert: Break performance bots. Original issue's description: > Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a single frame. > > BUG=webrtc:8028 > > Review-Url: https://codereview.webrtc.org/2993513002 > Cr-Commit-Position: refs/heads/master@{#19209} > Committed: https://chromium.googlesource.com/external/webrtc/+/ee13e8919c20de5860a510e91fac71fd5a7e9b8d TBR=stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:8028 Review-Url: https://codereview.webrtc.org/2990183002 Cr-Commit-Position: refs/heads/master@{#19211} Committed: https://chromium.googlesource.com/external/webrtc/+/c18f1d7c9432a2bf7d112820eb2b1dd2dbe2ba4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -92 lines) Patch
M webrtc/modules/video_coding/frame_object.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_object.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/packet_buffer.cc View 3 chunks +6 lines, -20 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 3 chunks +2 lines, -70 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
philipel
Created Revert of Fix off-by-one bugs in video_coding::PacketBuffer when the buffer is filled with a ...
3 years, 4 months ago (2017-08-02 11:17:51 UTC) #2
philipel
3 years, 4 months ago (2017-08-03 08:52:28 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2989313003/ by philipel@webrtc.org.

The reason for reverting is: Revert to create fix CL..

Powered by Google App Engine
This is Rietveld 408576698