Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: runtime/vm/dart.cc

Issue 2990173002: Revert "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, o… (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart.cc
diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc
index a538db2b7839bf464057b5db7a1b04e726b1f9a3..4553d1b5f9e483e93de952100bcda410fe1d6e92 100644
--- a/runtime/vm/dart.cc
+++ b/runtime/vm/dart.cc
@@ -150,7 +150,10 @@ char* Dart::InitOnce(const uint8_t* vm_isolate_snapshot,
ForwardingCorpse::InitOnce();
Api::InitOnce();
NOT_IN_PRODUCT(CodeObservers::InitOnce());
- NOT_IN_PRODUCT(Profiler::InitOnce());
+ if (FLAG_profiler) {
+ ThreadInterrupter::InitOnce();
+ Profiler::InitOnce();
+ }
SemiSpace::InitOnce();
NOT_IN_PRODUCT(Metric::InitOnce());
StoreBuffer::InitOnce();
@@ -351,13 +354,14 @@ const char* Dart::Cleanup() {
UptimeMillis());
}
-#if !defined(PRODUCT)
- if (FLAG_trace_shutdown) {
- OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Shutting down profiling\n",
- UptimeMillis());
+ if (FLAG_profiler) {
+ // Shut down profiling.
+ if (FLAG_trace_shutdown) {
+ OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Shutting down profiling\n",
+ UptimeMillis());
+ }
+ Profiler::Shutdown();
}
- Profiler::Shutdown();
-#endif // !defined(PRODUCT)
{
// Set the VM isolate as current isolate when shutting down
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/flag_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698