Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: runtime/bin/main.cc

Issue 2990173002: Revert "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, o… (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/class_allocation_profile.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <stdio.h> 5 #include <stdio.h>
6 #include <stdlib.h> 6 #include <stdlib.h>
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "include/dart_api.h" 9 #include "include/dart_api.h"
10 #include "include/dart_tools_api.h" 10 #include "include/dart_tools_api.h"
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 DEFAULT_VM_SERVICE_SERVER_PORT, DEFAULT_VM_SERVICE_SERVER_IP)) { 449 DEFAULT_VM_SERVICE_SERVER_PORT, DEFAULT_VM_SERVICE_SERVER_IP)) {
450 Log::PrintErr( 450 Log::PrintErr(
451 "unrecognized --observe option syntax. " 451 "unrecognized --observe option syntax. "
452 "Use --observe[=<port number>[/<bind address>]]\n"); 452 "Use --observe[=<port number>[/<bind address>]]\n");
453 return false; 453 return false;
454 } 454 }
455 455
456 // These options should also be documented in the help message. 456 // These options should also be documented in the help message.
457 vm_options->AddArgument("--pause-isolates-on-exit"); 457 vm_options->AddArgument("--pause-isolates-on-exit");
458 vm_options->AddArgument("--pause-isolates-on-unhandled-exceptions"); 458 vm_options->AddArgument("--pause-isolates-on-unhandled-exceptions");
459 vm_options->AddArgument("--profiler");
460 vm_options->AddArgument("--warn-on-pause-with-no-debugger"); 459 vm_options->AddArgument("--warn-on-pause-with-no-debugger");
461 return true; 460 return true;
462 } 461 }
463 462
464 static bool ProcessTraceLoadingOption(const char* arg, 463 static bool ProcessTraceLoadingOption(const char* arg,
465 CommandLineOptions* vm_options) { 464 CommandLineOptions* vm_options) {
466 if (*arg != '\0') { 465 if (*arg != '\0') {
467 return false; 466 return false;
468 } 467 }
469 trace_loading = true; 468 trace_loading = true;
(...skipping 1435 matching lines...) Expand 10 before | Expand all | Expand 10 after
1905 Platform::Exit(Process::GlobalExitCode()); 1904 Platform::Exit(Process::GlobalExitCode());
1906 } 1905 }
1907 1906
1908 } // namespace bin 1907 } // namespace bin
1909 } // namespace dart 1908 } // namespace dart
1910 1909
1911 int main(int argc, char** argv) { 1910 int main(int argc, char** argv) {
1912 dart::bin::main(argc, argv); 1911 dart::bin::main(argc, argv);
1913 UNREACHABLE(); 1912 UNREACHABLE();
1914 } 1913 }
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/class_allocation_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698